| Message ID | 1621389170-5850-1-git-send-email-wangqing@vivo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | staging: iio: fix some formatting issues | expand |
Hi Wang, Nice patch for a start. Yet, I think there is room for some improvement. On 05/19, Wang Qing wrote: > fixing: If you wish, you may add here that this style check is reported by checkpatch. > CHECK: Alignment should match open parenthesis > #1351: FILE: drivers/staging/iio/addac/adt7316.c:1351: Checkpatch warns that commit log lines starting with '#' are dropped by git as comments. Is this intentional? > > CHECK: Alignment should match open parenthesis > #1378: FILE: drivers/staging/iio/addac/adt7316.c:1378: Same warning here. Its probably not a requirement, but the subject line could be more specific about where the changes are for. Maybe start with staging: iio: addac: or even staging: iio: addac: adt7316: Regards, Marcelo > > Signed-off-by: Wang Qing <wangqing@vivo.com> > --- > drivers/staging/iio/addac/adt7316.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > index ccbafca..79467f0 100644 > --- a/drivers/staging/iio/addac/adt7316.c > +++ b/drivers/staging/iio/addac/adt7316.c > @@ -1348,9 +1348,9 @@ static ssize_t adt7316_show_in_analog_temp_offset(struct device *dev, > } > > static ssize_t adt7316_store_in_analog_temp_offset(struct device *dev, > - struct device_attribute *attr, > - const char *buf, > - size_t len) > + struct device_attribute *attr, > + const char *buf, > + size_t len) > { > struct iio_dev *dev_info = dev_to_iio_dev(dev); > struct adt7316_chip_info *chip = iio_priv(dev_info); > @@ -1375,9 +1375,9 @@ static ssize_t adt7316_show_ex_analog_temp_offset(struct device *dev, > } > > static ssize_t adt7316_store_ex_analog_temp_offset(struct device *dev, > - struct device_attribute *attr, > - const char *buf, > - size_t len) > + struct device_attribute *attr, > + const char *buf, > + size_t len) > { > struct iio_dev *dev_info = dev_to_iio_dev(dev); > struct adt7316_chip_info *chip = iio_priv(dev_info); > -- > 2.7.4 >
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index ccbafca..79467f0 100644 --- a/drivers/staging/iio/addac/adt7316.c +++ b/drivers/staging/iio/addac/adt7316.c @@ -1348,9 +1348,9 @@ static ssize_t adt7316_show_in_analog_temp_offset(struct device *dev, } static ssize_t adt7316_store_in_analog_temp_offset(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *dev_info = dev_to_iio_dev(dev); struct adt7316_chip_info *chip = iio_priv(dev_info); @@ -1375,9 +1375,9 @@ static ssize_t adt7316_show_ex_analog_temp_offset(struct device *dev, } static ssize_t adt7316_store_ex_analog_temp_offset(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *dev_info = dev_to_iio_dev(dev); struct adt7316_chip_info *chip = iio_priv(dev_info);
fixing: CHECK: Alignment should match open parenthesis #1351: FILE: drivers/staging/iio/addac/adt7316.c:1351: CHECK: Alignment should match open parenthesis #1378: FILE: drivers/staging/iio/addac/adt7316.c:1378: Signed-off-by: Wang Qing <wangqing@vivo.com> --- drivers/staging/iio/addac/adt7316.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)