From patchwork Wed Feb 21 14:05:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Siqueira X-Patchwork-Id: 10232853 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AF86560209 for ; Wed, 21 Feb 2018 14:05:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CFBB28AE2 for ; Wed, 21 Feb 2018 14:05:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 91B4128AEA; Wed, 21 Feb 2018 14:05:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1622828970 for ; Wed, 21 Feb 2018 14:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933198AbeBUOFk (ORCPT ); Wed, 21 Feb 2018 09:05:40 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:44269 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933135AbeBUOFi (ORCPT ); Wed, 21 Feb 2018 09:05:38 -0500 Received: by mail-qt0-f193.google.com with SMTP id g60so1979901qtd.11; Wed, 21 Feb 2018 06:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=GFpdmKjjdOMkfIYcAdX8F/k+X9ZEzmB0yJrhzd7XNDU=; b=EMX1HMplCAEBsLvikjP9IKXzVScat9I8BeVdfKRSJk3QT/rAqivUWxZ7Gz/u8reuep XhUyd1I8MH6/6CR5P+W9TWxZYYn1XIWk8wwlPk73kZ2Ekpu13Fl3aJfVEpH9ew2f3oBZ 3MiNFPVV6s+xkK2/H8T/oF9+RyesmZ144i+H0vbiY8egIvoEx1DM0ABBzYWpCbig/+5C yCW5Im3+eNwhUOpJ9F9u6dpCoPDMgl5NLyLLD/9lDGie2D+3RUy0jLa9uiXxm6YerU42 7qL2GFB1K63NT92rusmkLE0Rc9eBff80tFie5ZOKbs95pWA00hq6pTwNBETbMn1fCdxJ MaPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=GFpdmKjjdOMkfIYcAdX8F/k+X9ZEzmB0yJrhzd7XNDU=; b=JHWo3v9nLwhSv8d+d/dvNqBKWVojgUMk9RlctZAwfmSDoVOKYN9VVk4OC97ag8V4dr JrOyfSP5XR7DPlRPW3kD0NVLuX6xtp63vquLR14WmDuhUGDGWTK74wwdfj5f19pJXMHO 2eD+B3A/yy1xX2kUjndy6Fq3ePIityWDMg/vl3yCppAUd59tKIja8eij+Dd/HStA3Ore 7kF/1SPo7VCe7uQfo4By8/zqFUZLsRCTRD/0ESAO2lur3EafYCbkgihfInA7YrHyfGqV 2X+DxZmgidvAtlq7n04xiOwfFj3Bx9jtm/8xLwIOoGZmISdSNDnmzeJ7sbyy1qYrhD6S HmVQ== X-Gm-Message-State: APf1xPBOmU4l9gDlyOqk07gN9Cb97QAtLB0BBrBHDSiusvQzFLaESaWP jogg3JQMiSY4N9qSW/VXQwY= X-Google-Smtp-Source: AH8x227iyIfYTa7zcQSXLLFFBSpVOsgxu4IJI4gsBzdyXawcfuScWr7ANn/IPg0vL92bqlD33W/iHA== X-Received: by 10.200.67.15 with SMTP id z15mr5398593qtm.197.1519221937237; Wed, 21 Feb 2018 06:05:37 -0800 (PST) Received: from smtp.gmail.com ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id h127sm10576771qkc.70.2018.02.21.06.05.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Feb 2018 06:05:36 -0800 (PST) Date: Wed, 21 Feb 2018 11:05:33 -0300 From: Rodrigo Siqueira To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: daniel.baluta@nxp.com, linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen Message-ID: <20180221140533.lll6vbwg3gyjrlvi@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20171215 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the following checkpatch.pl warnings: drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should align the * on each line drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'... drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Rodrigo Siqueira --- drivers/iio/dummy/iio_dummy_evgen.c | 20 ++++++++++---------- drivers/iio/dummy/iio_simple_dummy.c | 3 ++- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c index efd0005f59b4..16ea547f79f0 100644 --- a/drivers/iio/dummy/iio_dummy_evgen.c +++ b/drivers/iio/dummy/iio_dummy_evgen.c @@ -148,16 +148,16 @@ static ssize_t iio_evgen_poke(struct device *dev, return len; } -static IIO_DEVICE_ATTR(poke_ev0, S_IWUSR, NULL, &iio_evgen_poke, 0); -static IIO_DEVICE_ATTR(poke_ev1, S_IWUSR, NULL, &iio_evgen_poke, 1); -static IIO_DEVICE_ATTR(poke_ev2, S_IWUSR, NULL, &iio_evgen_poke, 2); -static IIO_DEVICE_ATTR(poke_ev3, S_IWUSR, NULL, &iio_evgen_poke, 3); -static IIO_DEVICE_ATTR(poke_ev4, S_IWUSR, NULL, &iio_evgen_poke, 4); -static IIO_DEVICE_ATTR(poke_ev5, S_IWUSR, NULL, &iio_evgen_poke, 5); -static IIO_DEVICE_ATTR(poke_ev6, S_IWUSR, NULL, &iio_evgen_poke, 6); -static IIO_DEVICE_ATTR(poke_ev7, S_IWUSR, NULL, &iio_evgen_poke, 7); -static IIO_DEVICE_ATTR(poke_ev8, S_IWUSR, NULL, &iio_evgen_poke, 8); -static IIO_DEVICE_ATTR(poke_ev9, S_IWUSR, NULL, &iio_evgen_poke, 9); +static IIO_DEVICE_ATTR(poke_ev0, 0200, NULL, &iio_evgen_poke, 0); +static IIO_DEVICE_ATTR(poke_ev1, 0200, NULL, &iio_evgen_poke, 1); +static IIO_DEVICE_ATTR(poke_ev2, 0200, NULL, &iio_evgen_poke, 2); +static IIO_DEVICE_ATTR(poke_ev3, 0200, NULL, &iio_evgen_poke, 3); +static IIO_DEVICE_ATTR(poke_ev4, 0200, NULL, &iio_evgen_poke, 4); +static IIO_DEVICE_ATTR(poke_ev5, 0200, NULL, &iio_evgen_poke, 5); +static IIO_DEVICE_ATTR(poke_ev6, 0200, NULL, &iio_evgen_poke, 6); +static IIO_DEVICE_ATTR(poke_ev7, 0200, NULL, &iio_evgen_poke, 7); +static IIO_DEVICE_ATTR(poke_ev8, 0200, NULL, &iio_evgen_poke, 8); +static IIO_DEVICE_ATTR(poke_ev9, 0200, NULL, &iio_evgen_poke, 9); static struct attribute *iio_evgen_attrs[] = { &iio_dev_attr_poke_ev0.dev_attr.attr, diff --git a/drivers/iio/dummy/iio_simple_dummy.c b/drivers/iio/dummy/iio_simple_dummy.c index 62052479c349..fcfc38d4bd93 100644 --- a/drivers/iio/dummy/iio_simple_dummy.c +++ b/drivers/iio/dummy/iio_simple_dummy.c @@ -599,7 +599,7 @@ static struct iio_sw_device *iio_dummy_probe(const char *name) * indio_dev->dev.parent = &client->dev; */ - /* + /* * Make the iio_dev struct available to remove function. * Bus equivalents * i2c_set_clientdata(client, indio_dev); @@ -690,6 +690,7 @@ static int iio_dummy_remove(struct iio_sw_device *swd) return 0; } + /** * module_iio_sw_device_driver() - device driver registration *