| Message ID | 20180402165953.9110-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2 Apr 2018 18:59:53 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > 'sca3000_configure_ring()' can fail, so test its return value and > propagate it if needed. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Un-tested and not 100% sure that we should bail-out if it fails. Good catch - and yes we should bail out on error here. I'll pick this one up when we finish discussion of patch 1. (or possibly in v2 if you agree with my suggestion there). Thanks, Jonathan > --- > drivers/iio/accel/sca3000.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c > index dae4c594c170..45285edd216f 100644 > --- a/drivers/iio/accel/sca3000.c > +++ b/drivers/iio/accel/sca3000.c > @@ -1486,7 +1486,9 @@ static int sca3000_probe(struct spi_device *spi) > } > indio_dev->modes = INDIO_DIRECT_MODE; > > - sca3000_configure_ring(indio_dev); > + ret = sca3000_configure_ring(indio_dev); > + if (ret) > + return ret; > > if (spi->irq) { > ret = request_threaded_irq(spi->irq, -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index dae4c594c170..45285edd216f 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -1486,7 +1486,9 @@ static int sca3000_probe(struct spi_device *spi) } indio_dev->modes = INDIO_DIRECT_MODE; - sca3000_configure_ring(indio_dev); + ret = sca3000_configure_ring(indio_dev); + if (ret) + return ret; if (spi->irq) { ret = request_threaded_irq(spi->irq,
'sca3000_configure_ring()' can fail, so test its return value and propagate it if needed. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Un-tested and not 100% sure that we should bail-out if it fails. --- drivers/iio/accel/sca3000.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)