| Message ID | 20180518001446.15607-1-mkelly@xevo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 17 May 2018 17:14:45 -0700 Martin Kelly <mkelly@xevo.com> wrote: > Several types are mismatched and causing implicit conversions. Fix them > up so the types match. > > Signed-off-by: Martin Kelly <mkelly@xevo.com> Whilst I find it hard to care much about these, there might be a possible bug as a result, so fair enough to clean them up. Applied to the togreg branch of iio.git and pushed out as testing. Jonathan > --- > tools/iio/iio_generic_buffer.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c > index f0c6f54a8b2f..aa765c11992b 100644 > --- a/tools/iio/iio_generic_buffer.c > +++ b/tools/iio/iio_generic_buffer.c > @@ -334,7 +334,10 @@ int main(int argc, char **argv) > unsigned long timedelay = 1000000; > unsigned long buf_len = 128; > > - int ret, c, i, j, toread; > + ssize_t i; > + unsigned long j; > + unsigned long toread; > + int ret, c; > int fp = -1; > > int num_channels = 0; -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/20/2018 06:55 AM, Jonathan Cameron wrote: > On Thu, 17 May 2018 17:14:45 -0700 > Martin Kelly <mkelly@xevo.com> wrote: > >> Several types are mismatched and causing implicit conversions. Fix them >> up so the types match. >> >> Signed-off-by: Martin Kelly <mkelly@xevo.com> > Whilst I find it hard to care much about these, there might be a possible > bug as a result, so fair enough to clean them up. > > Applied to the togreg branch of iio.git and pushed out as testing. > > Jonathan Indeed, I doubt this will cause problems, but it can't hurt. This was a "while I was at it" fix for patch 2, which was the change I really wanted :). -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c index f0c6f54a8b2f..aa765c11992b 100644 --- a/tools/iio/iio_generic_buffer.c +++ b/tools/iio/iio_generic_buffer.c @@ -334,7 +334,10 @@ int main(int argc, char **argv) unsigned long timedelay = 1000000; unsigned long buf_len = 128; - int ret, c, i, j, toread; + ssize_t i; + unsigned long j; + unsigned long toread; + int ret, c; int fp = -1; int num_channels = 0;
Several types are mismatched and causing implicit conversions. Fix them up so the types match. Signed-off-by: Martin Kelly <mkelly@xevo.com> --- tools/iio/iio_generic_buffer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)