diff mbox series

iio: light: si1133: fix uninitialized resp variable

Message ID 20180731192651.29128-1-maxime.roussinbelanger@gmail.com (mailing list archive)
State New, archived
Headers show
Series iio: light: si1133: fix uninitialized resp variable | expand

Commit Message

Maxime Roussin-Bélanger July 31, 2018, 7:26 p.m. UTC 
Read response register to detect any error.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/iio/light/si1133.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Himanshu Jha July 31, 2018, 8 p.m. UTC | #1 
On Tue, Jul 31, 2018 at 03:26:51PM -0400, Maxime Roussin-Bélanger wrote:
> Read response register to detect any error.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

Missing Signed-off-by: ?

Thanks
diff mbox series

Patch

diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
index d3fbeb3bc463..9b8862af0127 100644
--- a/drivers/iio/light/si1133.c
+++ b/drivers/iio/light/si1133.c
@@ -409,6 +409,9 @@  static int si1133_command(struct si1133_data *data, u8 cmd)
 			err = -ETIMEDOUT;
 			goto out;
 		}
+		err = regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp);
+		if (err)
+			goto out;
 	} else {
 		err = regmap_read_poll_timeout(data->regmap,
 					       SI1133_REG_RESPONSE0, resp,