| Message ID | 20180815162349.GA3458@embeddedor.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: health: max30102: Mark expected switch fall-throughs | expand |
On Wed, 15 Aug 2018 11:23:49 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I placed the "fall through" > annotation at the bottom of the case, which is what GCC is expecting > to find. > > Addresses-Coverity-ID: 1458342 ("Missing break in switch") > Addresses-Coverity-ID: 1458345 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/health/max30102.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c > index 15ccadc..3e29562 100644 > --- a/drivers/iio/health/max30102.c > +++ b/drivers/iio/health/max30102.c > @@ -282,9 +282,11 @@ static int max30102_read_measurement(struct max30102_data *data, > switch (measurements) { > case 3: > MAX30102_COPY_DATA(2); > - case 2: /* fall-through */ > + /* fall through */ > + case 2: > MAX30102_COPY_DATA(1); > - case 1: /* fall-through */ > + /* fall through */ > + case 1: > MAX30102_COPY_DATA(0); > break; > default:
diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c index 15ccadc..3e29562 100644 --- a/drivers/iio/health/max30102.c +++ b/drivers/iio/health/max30102.c @@ -282,9 +282,11 @@ static int max30102_read_measurement(struct max30102_data *data, switch (measurements) { case 3: MAX30102_COPY_DATA(2); - case 2: /* fall-through */ + /* fall through */ + case 2: MAX30102_COPY_DATA(1); - case 1: /* fall-through */ + /* fall through */ + case 1: MAX30102_COPY_DATA(0); break; default:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I placed the "fall through" annotation at the bottom of the case, which is what GCC is expecting to find. Addresses-Coverity-ID: 1458342 ("Missing break in switch") Addresses-Coverity-ID: 1458345 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/iio/health/max30102.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)