From patchwork Wed Aug 15 20:38:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Frey X-Patchwork-Id: 10566827 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5C62914E1 for ; Wed, 15 Aug 2018 20:35:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C0E52ACA9 for ; Wed, 15 Aug 2018 20:35:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1063F2AE95; Wed, 15 Aug 2018 20:35:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B48472ACA9 for ; Wed, 15 Aug 2018 20:35:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbeHOX3Y (ORCPT ); Wed, 15 Aug 2018 19:29:24 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:45647 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbeHOX3Y (ORCPT ); Wed, 15 Aug 2018 19:29:24 -0400 Received: by mail-pl0-f65.google.com with SMTP id j8-v6so943767pll.12; Wed, 15 Aug 2018 13:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AK44yoKjkmP4QPzruZtsRIUollCXu93gsO7hU9ANqrs=; b=oIZFjDgGOo3pzgu+vE6x055vtRdB1SZAb/mvcUpof884DoTPb+pFabJGth9GwdwbjS s6s2t04lnduddgApRaszab8Vp3gJYAcj/Xek471qWOaNT+fg8t2lng1ZJk5SdSurQsPZ iXosgY8NE9BAB+/uZ5QD2mZNm7EeeVP4o1JBf9hUYdUG29mhEYf6eIqkHvMI+hf/mKno CgjUHam53EdnMs8L2QJxirH3SAoNcyLXlnAFwgW7KzU8smKDoZu82kleWdZGcc3o6aX0 3XWKzgwtusnSIKR4pc0GFZZdYqi9Zi3ejs6mrub3wTJMplUpI9rrF80g3j6AAr0tKBFg ywOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AK44yoKjkmP4QPzruZtsRIUollCXu93gsO7hU9ANqrs=; b=nssjIwZrZ7MEP1ZcYjsr6WM0HxWP2Dmmrtg1rx1UR0RymwJPxrId1DyOpv8qW4uw9B MdNjmzlf9IVOdW4F+v2AGFYjCMCsa24cDIiWByRZoCINO9siL6arspBPOYW2qMyOsmLm Da/AxPJgHEpkpH4vMB4ebRFfWj6EuvMduW8+Lx8uOaauGIlaRbFGKifn1DbzKQRve2AP TsNViT03iKF6rmrvfrvgsBr4aK8WysIouiBNdGX12ewGzY8o2j3i5et7AoiznBPwcJQ/ GXiFG6ZZcsXPEqcZe9qOnqfSfsyAJ97CD0LU2x+igKVX98oPwBt9AD5lVhQpV7eKVewi 4UWw== X-Gm-Message-State: AOUpUlFBIGuzU+uYG/nVO6tjQAk8yufwrWwjRT6cGzDgx6aP631Tv5LD c2+799kJeuCVH2emp55Tx2NBECag X-Google-Smtp-Source: AA+uWPycZETylRl2ofdDWVg58nXMM2dMefM6BF0zGZ9WOKoX+adplHzFEXKFF3aoxLcxExTrVb7vbw== X-Received: by 2002:a17:902:9a83:: with SMTP id w3-v6mr25910518plp.75.1534365340077; Wed, 15 Aug 2018 13:35:40 -0700 (PDT) Received: from dfrey-debian-linux.sierrawireless.local ([185.153.179.9]) by smtp.gmail.com with ESMTPSA id d9-v6sm35784055pfb.86.2018.08.15.13.35.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 13:35:39 -0700 (PDT) From: David Frey To: linux-iio@vger.kernel.org Cc: jic23@vger.kernel.org, himanshujha199640@gmail.com, David Frey Subject: [PATCH v2 6/7] iio: chemical: bme680: use FIELD_GET macro Date: Wed, 15 Aug 2018 13:38:34 -0700 Message-Id: <20180815203835.21079-7-dpfrey@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180815203835.21079-1-dpfrey@gmail.com> References: <20180815203835.21079-1-dpfrey@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use the FIELD_GET macro instead of explicit mask and shift. Signed-off-by: David Frey --- drivers/iio/chemical/bme680_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c index d62cb88af481..c96e4a991a61 100644 --- a/drivers/iio/chemical/bme680_core.c +++ b/drivers/iio/chemical/bme680_core.c @@ -285,7 +285,7 @@ static int bme680_read_calib(struct bme680_data *data, dev_err(dev, "failed to read resistance heat range\n"); return ret; } - calib->res_heat_range = (tmp & BME680_RHRANGE_MASK) / 16; + calib->res_heat_range = FIELD_GET(BME680_RHRANGE_MASK, tmp); ret = regmap_read(data->regmap, BME680_REG_RES_HEAT_VAL, &tmp); if (ret < 0) { @@ -299,7 +299,7 @@ static int bme680_read_calib(struct bme680_data *data, dev_err(dev, "failed to read range software error\n"); return ret; } - calib->range_sw_err = (tmp & BME680_RSERROR_MASK) / 16; + calib->range_sw_err = FIELD_GET(BME680_RSERROR_MASK, tmp); return 0; }