From patchwork Fri Aug 17 19:03:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Frey X-Patchwork-Id: 10569295 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06EAC1390 for ; Fri, 17 Aug 2018 19:02:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EAB9C29ECC for ; Fri, 17 Aug 2018 19:02:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D97352A22C; Fri, 17 Aug 2018 19:02:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A7F029ECC for ; Fri, 17 Aug 2018 19:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbeHQWHZ (ORCPT ); Fri, 17 Aug 2018 18:07:25 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:43770 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727995AbeHQWHY (ORCPT ); Fri, 17 Aug 2018 18:07:24 -0400 Received: by mail-pf1-f194.google.com with SMTP id j26-v6so3873584pfi.10 for ; Fri, 17 Aug 2018 12:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vB7kbCxn9eSm7X+KHLhE34RdHb0fmJruT93NCyWQyFw=; b=YimpUVdQ6Ux7zbgoa7ObykztoPx8FE4wxDT7Q1KyCWYQqCJDHEYmVZbK/hbeBf8/sW uo4fFUW27wW4dxYfjBECISTWZf3KgHvzZunMcIm1YYmFr7YbGpCKd8OCpGHzh68002Pw VJq0SfC0rAc5Kb3nVPX/h3K/M/hOiOjYesAjt1vcfQ/pathxF2Zgq0EUnilDP0lnzcYC E9Es0XBEeQzWnydc/Zi02P9OtqroBkHqJ0xgl7lmR6/P7kEW6M/wZLbrUvnlg9NL0eOU JZt9OZJ7QT+sbqgMbjfFQH/PdEyUQGEk6GlpFd9uw+rABP65yNjVkANlz5WhT/1/MknX 8C+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vB7kbCxn9eSm7X+KHLhE34RdHb0fmJruT93NCyWQyFw=; b=bET0po7soFLNrrVYXy8jpCsaWsk4M37YMjxJNAVN0ePvPVMNBCReCY9hTWdBqV/mEw uDV2tyPmAQbmb/jUFGIlV9c6n53I4VnH2k1VhCECX2gjBG6t8klC3k2XIoM0GHxn1xBY nA8NToHn6cvSE2u01tOxlx7StIgqRFBzPK7jgfIq4i0PbbBNH3n0+PS40Nyokrnvy5Q9 CKosdGbta6dIlJKQBtlTPjO6T3ng4NLkv51TVv3WynOZ3t8xK14aU0FfFhT/13TrQWI0 EOjN++PQHqBpyu08e9EK/gaD13yT0nwCCub+RjZwgkG4gcOQez0I6MnkddPXyZlmmkPQ vjtA== X-Gm-Message-State: AOUpUlEcOZvOyHrARUljUI/PhiTEft9ybNLk1mD8gP5q/EEYz74SM5lA Lv6iYXEkxbL0ay4jkB5+aFg7Ccs6 X-Google-Smtp-Source: AA+uWPwfbJKD9Fn2xwnJqNKSrN5q9whaLpUmaHgpnblrU4G/KobpHQPs0au4DDZBbpJXHQLQ5boZqg== X-Received: by 2002:a63:e457:: with SMTP id i23-v6mr34196204pgk.127.1534532572994; Fri, 17 Aug 2018 12:02:52 -0700 (PDT) Received: from dfrey-debian-linux.sierrawireless.local ([185.153.179.9]) by smtp.gmail.com with ESMTPSA id z22-v6sm6491358pgc.67.2018.08.17.12.02.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 12:02:22 -0700 (PDT) From: David Frey To: linux-iio@vger.kernel.org Cc: jic23@kernel.org, himanshujha199640@gmail.com, David Frey Subject: [PATCH v3 5/7] iio: chemical: bme680: use GENMASK macro Date: Fri, 17 Aug 2018 12:03:17 -0700 Message-Id: <20180817190319.13119-6-dpfrey@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180817190319.13119-1-dpfrey@gmail.com> References: <20180817190319.13119-1-dpfrey@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace hardcoded bit masks with GENMASK macro Signed-off-by: David Frey Reviewed-by: Himanshu Jha Tested-by: Himanshu Jha --- drivers/iio/chemical/bme680.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h index 437d75c2bad5..a9f2a9a6abc5 100644 --- a/drivers/iio/chemical/bme680.h +++ b/drivers/iio/chemical/bme680.h @@ -18,7 +18,7 @@ #define BME680_REG_GAS_MSB 0x2A #define BME680_REG_GAS_R_LSB 0x2B #define BME680_GAS_STAB_BIT BIT(4) -#define BME680_GAS_RANGE_MASK 0x0F +#define BME680_GAS_RANGE_MASK GENMASK(3, 0) #define BME680_REG_CTRL_HUMIDITY 0x72 #define BME680_OSRS_HUMIDITY_MASK GENMASK(2, 0) @@ -39,13 +39,13 @@ #define BME680_MAX_OVERFLOW_VAL 0x40000000 #define BME680_HUM_REG_SHIFT_VAL 4 -#define BME680_BIT_H1_DATA_MASK 0x0F +#define BME680_BIT_H1_DATA_MASK GENMASK(3, 0) #define BME680_REG_RES_HEAT_RANGE 0x02 -#define BME680_RHRANGE_MASK 0x30 +#define BME680_RHRANGE_MASK GENMASK(5, 4) #define BME680_REG_RES_HEAT_VAL 0x00 #define BME680_REG_RANGE_SW_ERR 0x04 -#define BME680_RSERROR_MASK 0xF0 +#define BME680_RSERROR_MASK GENMASK(7, 4) #define BME680_REG_RES_HEAT_0 0x5A #define BME680_REG_GAS_WAIT_0 0x64 #define BME680_ADC_GAS_RES_SHIFT 6