From patchwork Fri Aug 17 19:03:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Frey X-Patchwork-Id: 10569297 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E30D01390 for ; Fri, 17 Aug 2018 19:03:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D33812A677 for ; Fri, 17 Aug 2018 19:03:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C66B02A696; Fri, 17 Aug 2018 19:03:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 707932A677 for ; Fri, 17 Aug 2018 19:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728041AbeHQWHn (ORCPT ); Fri, 17 Aug 2018 18:07:43 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:45863 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727995AbeHQWHn (ORCPT ); Fri, 17 Aug 2018 18:07:43 -0400 Received: by mail-pl0-f68.google.com with SMTP id j8-v6so4101875pll.12 for ; Fri, 17 Aug 2018 12:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FbPqETxP3MqZM8imy3ulQ1hh/ljLzQ+hZtJWG2ibBHU=; b=XtUCQshaiK2LKb/NXub1c9bODBN2PHjaAw9W5SFYsGRczaE2b16MtmoQwcJbCoIMf4 e1VireOVg8jmW1EmXn6m7wB2XxjVsy1ivTMp73mmN9IPFK8ycWBuDyVP/XnCbs417cHk +SO6nNlcIB2oJWhaTtb31yloMDWJ+nQtoRSAGPc34lERM76yJUA/x+OYCT+ZCwxKmtc7 q0oy4fhlJIIEiRRjGg+G5HjHsbfF7bZ2ljZta2otFKKuMlI3K+c7ZX9vLtwqm0HF9897 ulOOzcqajdd5PLYeOcSnWsYod9Z9eVQqU0CdqZDTCuE+xBKFDepxRHPo68d/jeqX7Ehm IyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FbPqETxP3MqZM8imy3ulQ1hh/ljLzQ+hZtJWG2ibBHU=; b=amMCUJ1iQOb+IaA4j/uy3LkIR7s8wkufUThlqzPdcFaWC9Pk6slBV0rEuEiRETET8K WOqQf6NWcMeuePcxiCHOUHM0xz59OgBipmhn91e9mEBMKBXYsDIfymNq9AMjRApg6k4f TP1U+K4N7pyDy60KKbEFrMYEtwOvFY7tNRfVqcWW7VT56ztxbHeBrwWCS1YjN+eBkUVU nOoP+aY1CLvg4LJaRTySeeHZRkFAmP+exJPNVo7G5vFUjgX7HstVIYpUhp/MtcxjB0hW 6/tXqQJd1zlqF0eJAiCSHUts8zU5t6K35dVpmlFqkQO8ZP0hW40MRO9j0+pVYk+e5HU3 aajA== X-Gm-Message-State: AOUpUlGyJvy9jl2mU+zAGEL/rhITxwUDoabkewxsL0SsVaJJ60wJVLkI p8QtAHXgQHShVofxr585vWQqDlUl X-Google-Smtp-Source: AA+uWPyIHB/tZ+7ItYO8+/fhvHUK0IKv72RTEXhshKy380HeChA3Y0W2MO81mLUMqUIsbxI5dlmeZw== X-Received: by 2002:a17:902:4401:: with SMTP id k1-v6mr34152791pld.97.1534532591055; Fri, 17 Aug 2018 12:03:11 -0700 (PDT) Received: from dfrey-debian-linux.sierrawireless.local ([185.153.179.9]) by smtp.gmail.com with ESMTPSA id z22-v6sm6491358pgc.67.2018.08.17.12.03.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 12:03:10 -0700 (PDT) From: David Frey To: linux-iio@vger.kernel.org Cc: jic23@kernel.org, himanshujha199640@gmail.com, David Frey Subject: [PATCH v3 6/7] iio: chemical: bme680: use FIELD_GET macro Date: Fri, 17 Aug 2018 12:03:18 -0700 Message-Id: <20180817190319.13119-7-dpfrey@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180817190319.13119-1-dpfrey@gmail.com> References: <20180817190319.13119-1-dpfrey@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use the FIELD_GET macro instead of explicit mask and shift. Signed-off-by: David Frey Reviewed-by: Himanshu Jha Tested-by: Himanshu Jha --- drivers/iio/chemical/bme680_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c index 7c7df40b615f..46afc93041f5 100644 --- a/drivers/iio/chemical/bme680_core.c +++ b/drivers/iio/chemical/bme680_core.c @@ -285,7 +285,7 @@ static int bme680_read_calib(struct bme680_data *data, dev_err(dev, "failed to read resistance heat range\n"); return ret; } - calib->res_heat_range = (tmp & BME680_RHRANGE_MASK) / 16; + calib->res_heat_range = FIELD_GET(BME680_RHRANGE_MASK, tmp); ret = regmap_read(data->regmap, BME680_REG_RES_HEAT_VAL, &tmp); if (ret < 0) { @@ -299,7 +299,7 @@ static int bme680_read_calib(struct bme680_data *data, dev_err(dev, "failed to read range software error\n"); return ret; } - calib->range_sw_err = (tmp & BME680_RSERROR_MASK) / 16; + calib->range_sw_err = FIELD_GET(BME680_RSERROR_MASK, tmp); return 0; }