From patchwork Sat Aug 18 02:08:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiecheng Wu X-Patchwork-Id: 10569477 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8DED109C for ; Sat, 18 Aug 2018 02:08:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A32B2BCC5 for ; Sat, 18 Aug 2018 02:08:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E5982BCD1; Sat, 18 Aug 2018 02:08:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A5D82BCC5 for ; Sat, 18 Aug 2018 02:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725886AbeHRFOe (ORCPT ); Sat, 18 Aug 2018 01:14:34 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:34438 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbeHRFOd (ORCPT ); Sat, 18 Aug 2018 01:14:33 -0400 Received: by mail-pl0-f65.google.com with SMTP id f6-v6so4489703plo.1 for ; Fri, 17 Aug 2018 19:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=GC6GUIJBw+PJ4I8+phWCgx+303yS4eut9cAPJzsgpjI=; b=hdlF48JjREZU1FkdoelGDt351pOyKI52AGsD4zHksX+6jA3dl2KStLRP4R65hU4nEX OPAy6QuXTL0KXh86szdf9lQ7SfCw1/N52Vzwb4k3wgrZgBacxyLLrpUulJYZVSLFbxsz sJOnmoBMU6olBfA9CuCpP/dFgx5xvB51Zzqb83qR1RfbyBlW/bhCH4p3+felxLliiYJz ETRqcUXX7UOZxew3J8LxCSgCRE5+V6X2MPGHAxdrQkY5Jz45kM8Cf5+DlYgYKNwyzxHT z0lw7lb/ZmKBRdaVb7/+U/z8sGFXZnyrgHlLYA/CyfK2TJhJkvvbbkwhzjtPtsd/bang uE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=GC6GUIJBw+PJ4I8+phWCgx+303yS4eut9cAPJzsgpjI=; b=Zw6ldLA7vjrfd4CrnXqiyMtb+9xxle53QP5ZlTxKAffVMBepaZSwx3qI0nwiiid1Ye +h/aq32CqJTNra4s6igUoaU+q0RTXZeM4ZhVELizM3C0jdmokJx1nKI/FJMi74H4TIZL /0onV0h9mBaHXphaitPagM3cZ35O4cxVtQ+x2HIaLRGGEiM3Hr918wD5IpCyYK51b62z QQMyv2IS6GTGYQa9vAvZO5J7Ungj0HvwcdKrvm0lafqO19M+P+ofFzT7Qh5He7aYGoMD u8Wvi2bSuxVZxH6BcZNeyJ+2zJ1UxjS7BuGkY+C08vchaPCjQ66amr4NIO17c7Ql9Ywn HWZA== X-Gm-Message-State: AOUpUlHvp65IHMSKbDFu+QGwdcaN1wbGrvHSPEp/8peNVjWf/Yaa/LhZ meU1iE0S9ahoEPAAfybaXoL7vszIXb8PiQ== X-Google-Smtp-Source: AA+uWPx3jwdU375XBEA8kw2y3WQKfDoaCCeY5zhd2UaAqQccZuftJdY/4M1zu/hr3VvhZGTvm1kFSw== X-Received: by 2002:a17:902:e20b:: with SMTP id ce11-v6mr35585668plb.136.1534558122653; Fri, 17 Aug 2018 19:08:42 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:1501:200:5efe:a66f:53fa]) by smtp.gmail.com with ESMTPSA id z11-v6sm5106444pff.162.2018.08.17.19.08.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Aug 2018 19:08:42 -0700 (PDT) From: Jiecheng Wu To: linux-iio@vger.kernel.org Subject: [PATCH] hmc5843_i2c.c: fix missing return value check of devm_regmap_init_i2c() Date: Sat, 18 Aug 2018 10:08:33 +0800 Message-Id: <20180818020833.14376-1-jasonwood2031@gmail.com> X-Mailer: git-send-email 2.14.3.windows.1 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Function hmc5843_i2c_probe() defined in drivers/iio/magnetometer/hmc5843_i2c.c calls devm_regmap_init_i2c() to initialise managed register map. As the return value of devm_regmap_init_i2c() will be an ERR_PTR() on error, the return value must be checked against NULL. --- drivers/iio/magnetometer/hmc5843_i2c.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/hmc5843_i2c.c b/drivers/iio/magnetometer/hmc5843_i2c.c index 3de7f44..4911cf8 100644 --- a/drivers/iio/magnetometer/hmc5843_i2c.c +++ b/drivers/iio/magnetometer/hmc5843_i2c.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "hmc5843.h" @@ -58,8 +59,13 @@ static const struct regmap_config hmc5843_i2c_regmap_config = { static int hmc5843_i2c_probe(struct i2c_client *cli, const struct i2c_device_id *id) { - return hmc5843_common_probe(&cli->dev, - devm_regmap_init_i2c(cli, &hmc5843_i2c_regmap_config), + struct regmap *regmap; + regmap = devm_regmap_init_i2c(cli, &hmc5843_i2c_regmap_config); + if (IS_ERR(regmap)) { + dev_err(&cli->dev, "Failed to initialize i2c regmap\n"); + return PTR_ERR(regmap); + } + return hmc5843_common_probe(&cli->dev, regmap, id->driver_data, id->name); }