From patchwork Sun Aug 19 02:16:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiecheng Wu X-Patchwork-Id: 10569659 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D11BF13B6 for ; Sun, 19 Aug 2018 02:17:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3D0929EAB for ; Sun, 19 Aug 2018 02:17:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A444A29ED7; Sun, 19 Aug 2018 02:17:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D32829EAB for ; Sun, 19 Aug 2018 02:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725889AbeHSF0u (ORCPT ); Sun, 19 Aug 2018 01:26:50 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:42086 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbeHSF0u (ORCPT ); Sun, 19 Aug 2018 01:26:50 -0400 Received: by mail-pg1-f193.google.com with SMTP id y4-v6so5181065pgp.9 for ; Sat, 18 Aug 2018 19:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:signed-off-by; bh=Z33NT4QIYXbDp1fkt5N9146YSPFHMlXy9aX9By/XOQw=; b=CNtcpA9qyTtu7eFpvZk15ujy7dtLObBTQuPlJLsZdQweDX/RABZsZvtATtIqsCdsGL QoH8iO5wrziJbdai9QKerBDXG1Ya58O2c252eFGhmRF1XC/yO2ABafysTqqOmaJW7U/K eUaGvV/bXAQF6M3Wsvk5/Kknh3qCepUa6ngrZXlzD0PIJXfnIlRyYdfE0cSUgDBRIol9 iMokHp8jpa9auyi7KeMJGbeqXfGrTHolPiZ/XTevqGBwCe9R1PnVjAO/VTZbv6TsBQ4V cKo0zsi4Mdph0H9iDwrWWbLIH2GlmmWhMstiZ8en4h6fdPBntpIiuuUIcQwNibP2BJ6A +0Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:signed-off-by; bh=Z33NT4QIYXbDp1fkt5N9146YSPFHMlXy9aX9By/XOQw=; b=j2Qvl05lDP0LME+51ESbEJ1mzuKi9f+MM2fNte1pFMn5KKd2IMOTIDIWi2j3Wx6Mu2 DVmmp54nHke35Ioi6l4AO0jbHTzO9IlkWF6jlr/QyO6J1EsoMADAI4r6u4FBDe94LIUP b7fKPc/6m78ZrJ+lr/VHRRb2siAn1MhDBy8taCiyxlpudnyp+VuUwAfSajnHkfJqBPtc 4ab/Lu+iVbTQ1jfiI467IiP0mzicV0JDxvfsSKYEx6GOpu7MtXq1yWxSCOqwIygD5vaO RYFgfUBLZ5ZfxKqVCjm7ZNqpjNPZBigSDl6moK9nkZ9cM3l6I5R7Sk4DYZi0aRg6KMJp Zc6Q== X-Gm-Message-State: AOUpUlEkUqzQSmnXZGKKJXuKP0XswooxTWeV4pWUNPDOCziNdeEFRtLw S8AKd1Si//fEm6wyMoQN759eQIeY9U6I5A== X-Google-Smtp-Source: AA+uWPxUSqFffyD2rtXJPr6bFoqmhk1w3P+qn3KuFU/UCCSj9yzBudduWqPeaMsrfLis6mJe/EAwHw== X-Received: by 2002:a63:2352:: with SMTP id u18-v6mr112091pgm.202.1534645022508; Sat, 18 Aug 2018 19:17:02 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:1501:200:5efe:a66f:53fa]) by smtp.gmail.com with ESMTPSA id y86-v6sm9520875pfk.84.2018.08.18.19.17.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Aug 2018 19:17:02 -0700 (PDT) From: Jiecheng Wu To: linux-iio@vger.kernel.org Subject: [PATCH] hmc5843_i2c.c: fix missing return value check of devm_regmap_init_i2c() Date: Sun, 19 Aug 2018 10:16:41 +0800 Message-Id: <20180819021641.3068-1-jasonwood2031@gmail.com> X-Mailer: git-send-email 2.14.3.windows.1 Signed-off-by: Jiecheng Wu Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Function hmc5843_i2c_probe() defined in drivers/iio/magnetometer/hmc5843_i2c.c calls devm_regmap_init_i2c() to initialise managed register map. As the return value of devm_regmap_init_i2c() will be an ERR_PTR() on error, the return value must be checked against NULL. --- drivers/iio/magnetometer/hmc5843_i2c.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/hmc5843_i2c.c b/drivers/iio/magnetometer/hmc5843_i2c.c index 3de7f44..4911cf8 100644 --- a/drivers/iio/magnetometer/hmc5843_i2c.c +++ b/drivers/iio/magnetometer/hmc5843_i2c.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "hmc5843.h" @@ -58,8 +59,13 @@ static const struct regmap_config hmc5843_i2c_regmap_config = { static int hmc5843_i2c_probe(struct i2c_client *cli, const struct i2c_device_id *id) { - return hmc5843_common_probe(&cli->dev, - devm_regmap_init_i2c(cli, &hmc5843_i2c_regmap_config), + struct regmap *regmap; + regmap = devm_regmap_init_i2c(cli, &hmc5843_i2c_regmap_config); + if (IS_ERR(regmap)) { + dev_err(&cli->dev, "Failed to initialize i2c regmap\n"); + return PTR_ERR(regmap); + } + return hmc5843_common_probe(&cli->dev, regmap, id->driver_data, id->name); }