| Message ID | 20181001122834.GA13306@x220.localdomain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: adc: add missing spaces around minus sign | expand |
> The checkpatch.pl tool detected coding style problem: > > CHECK: spaces preferred around that '-' (ctx:VxV) oh no, not again please see e.g. https://lore.kernel.org/patchwork/patch/635994/ for some discussion why this patch doesn't make sense > in two files inside the adc directory. This patch will remove this > problem. > > Signed-off-by: Slawomir Stepien <sst@poczta.fm> > --- > drivers/staging/iio/adc/ad7192.c | 2 +- > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > index acdbc07fd259..7c632cf1932b 100644 > --- a/drivers/staging/iio/adc/ad7192.c > +++ b/drivers/staging/iio/adc/ad7192.c > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, > } > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > - in_voltage-voltage_scale_available, > + in_voltage - voltage_scale_available, > 0444, ad7192_show_scale_available, NULL, 0); > > static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c > index 58420dcb406d..a4b4f8678c56 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) > } > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > - in_voltage-voltage_thresh_low_value, > + in_voltage - voltage_thresh_low_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config, > AD7280A_CELL_UNDERVOLTAGE); > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > - in_voltage-voltage_thresh_high_value, > + in_voltage - voltage_thresh_high_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config, >
On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: > The checkpatch.pl tool detected coding style problem: > > CHECK: spaces preferred around that '-' (ctx:VxV) > > in two files inside the adc directory. This patch will remove this > problem. > > Signed-off-by: Slawomir Stepien <sst@poczta.fm> > --- > drivers/staging/iio/adc/ad7192.c | 2 +- > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > index acdbc07fd259..7c632cf1932b 100644 > --- a/drivers/staging/iio/adc/ad7192.c > +++ b/drivers/staging/iio/adc/ad7192.c > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, > } > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > - in_voltage-voltage_scale_available, > + in_voltage - voltage_scale_available, > 0444, ad7192_show_scale_available, NULL, 0); This doesn't work. That's not arithmatic, it's a string which is passed to a macro. It's an ugly macro, but it would take a lot of work to change it at this point. regards, dan carpenter
On 10/01/2018 02:52 PM, Dan Carpenter wrote: > On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: >> The checkpatch.pl tool detected coding style problem: >> >> CHECK: spaces preferred around that '-' (ctx:VxV) >> >> in two files inside the adc directory. This patch will remove this >> problem. >> >> Signed-off-by: Slawomir Stepien <sst@poczta.fm> >> --- >> drivers/staging/iio/adc/ad7192.c | 2 +- >> drivers/staging/iio/adc/ad7280a.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c >> index acdbc07fd259..7c632cf1932b 100644 >> --- a/drivers/staging/iio/adc/ad7192.c >> +++ b/drivers/staging/iio/adc/ad7192.c >> @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, >> } >> >> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, >> - in_voltage-voltage_scale_available, >> + in_voltage - voltage_scale_available, >> 0444, ad7192_show_scale_available, NULL, 0); > > > This doesn't work. That's not arithmatic, it's a string which is passed > to a macro. It's an ugly macro, but it would take a lot of work to > change it at this point. From a technical perspective it is easy to change this. We already had patches for that. The difficulty is convincing Greg that this would be a sensible change to pass the string as a string and not a preprocessor token.
On paź 01, 2018 14:51, Peter Meerwald-Stadler wrote: > > > The checkpatch.pl tool detected coding style problem: > > > > CHECK: spaces preferred around that '-' (ctx:VxV) > > oh no, not again > please see e.g. https://lore.kernel.org/patchwork/patch/635994/ > for some discussion why this patch doesn't make sense Oh...my mistake. Thank you for clarification. I should be more careful. Sorry! > > in two files inside the adc directory. This patch will remove this > > problem. > > > > Signed-off-by: Slawomir Stepien <sst@poczta.fm> > > --- > > drivers/staging/iio/adc/ad7192.c | 2 +- > > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > > index acdbc07fd259..7c632cf1932b 100644 > > --- a/drivers/staging/iio/adc/ad7192.c > > +++ b/drivers/staging/iio/adc/ad7192.c > > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, > > } > > > > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > > - in_voltage-voltage_scale_available, > > + in_voltage - voltage_scale_available, > > 0444, ad7192_show_scale_available, NULL, 0); > > > > static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c > > index 58420dcb406d..a4b4f8678c56 100644 > > --- a/drivers/staging/iio/adc/ad7280a.c > > +++ b/drivers/staging/iio/adc/ad7280a.c > > @@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) > > } > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > > - in_voltage-voltage_thresh_low_value, > > + in_voltage - voltage_thresh_low_value, > > 0644, > > ad7280_read_channel_config, > > ad7280_write_channel_config, > > AD7280A_CELL_UNDERVOLTAGE); > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > > - in_voltage-voltage_thresh_high_value, > > + in_voltage - voltage_thresh_high_value, > > 0644, > > ad7280_read_channel_config, > > ad7280_write_channel_config, > > >
On Mon, Oct 01, 2018 at 02:54:55PM +0200, Lars-Peter Clausen wrote: > On 10/01/2018 02:52 PM, Dan Carpenter wrote: > > On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: > >> The checkpatch.pl tool detected coding style problem: > >> > >> CHECK: spaces preferred around that '-' (ctx:VxV) > >> > >> in two files inside the adc directory. This patch will remove this > >> problem. > >> > >> Signed-off-by: Slawomir Stepien <sst@poczta.fm> > >> --- > >> drivers/staging/iio/adc/ad7192.c | 2 +- > >> drivers/staging/iio/adc/ad7280a.c | 4 ++-- > >> 2 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > >> index acdbc07fd259..7c632cf1932b 100644 > >> --- a/drivers/staging/iio/adc/ad7192.c > >> +++ b/drivers/staging/iio/adc/ad7192.c > >> @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, > >> } > >> > >> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > >> - in_voltage-voltage_scale_available, > >> + in_voltage - voltage_scale_available, > >> 0444, ad7192_show_scale_available, NULL, 0); > > > > > > This doesn't work. That's not arithmatic, it's a string which is passed > > to a macro. It's an ugly macro, but it would take a lot of work to > > change it at this point. > > >From a technical perspective it is easy to change this. We already had > patches for that. The difficulty is convincing Greg that this would be a > sensible change to pass the string as a string and not a preprocessor token. Oh. Hm... I was looking at this wrong. It would be awkward to make it a string because the _show() op names depend on the filename. People do keep bumping into this mistake, but there is no chance that anyone is going to merge it so it's probably not worth investing any more time on it. regards, dan carpenter
On Mon, 1 Oct 2018 16:35:33 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Mon, Oct 01, 2018 at 02:54:55PM +0200, Lars-Peter Clausen wrote: > > On 10/01/2018 02:52 PM, Dan Carpenter wrote: > > > On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote: > > >> The checkpatch.pl tool detected coding style problem: > > >> > > >> CHECK: spaces preferred around that '-' (ctx:VxV) > > >> > > >> in two files inside the adc directory. This patch will remove this > > >> problem. > > >> > > >> Signed-off-by: Slawomir Stepien <sst@poczta.fm> > > >> --- > > >> drivers/staging/iio/adc/ad7192.c | 2 +- > > >> drivers/staging/iio/adc/ad7280a.c | 4 ++-- > > >> 2 files changed, 3 insertions(+), 3 deletions(-) > > >> > > >> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > > >> index acdbc07fd259..7c632cf1932b 100644 > > >> --- a/drivers/staging/iio/adc/ad7192.c > > >> +++ b/drivers/staging/iio/adc/ad7192.c > > >> @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, > > >> } > > >> > > >> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > > >> - in_voltage-voltage_scale_available, > > >> + in_voltage - voltage_scale_available, > > >> 0444, ad7192_show_scale_available, NULL, 0); > > > > > > > > > This doesn't work. That's not arithmatic, it's a string which is passed > > > to a macro. It's an ugly macro, but it would take a lot of work to > > > change it at this point. > > > > >From a technical perspective it is easy to change this. We already had > > patches for that. The difficulty is convincing Greg that this would be a > > sensible change to pass the string as a string and not a preprocessor token. > > Oh. Hm... I was looking at this wrong. It would be awkward to make it > a string because the _show() op names depend on the filename. > > People do keep bumping into this mistake, but there is no chance that > anyone is going to merge it so it's probably not worth investing any > more time on it. > Or... Plan b) use the callbacks to generate this automatically and avoid having to have the macro use at all. In theory it was on the plan to get rid of all of these _available definitions in favour of ones that in kernel consumers can actually read easily, we just haven't made that much progress with it. Jonathan p.s. Good learning experience for people to discover that checkpatch isn't infallible? *ducks* > regards, > dan carpenter
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c index acdbc07fd259..7c632cf1932b 100644 --- a/drivers/staging/iio/adc/ad7192.c +++ b/drivers/staging/iio/adc/ad7192.c @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev, } static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, - in_voltage-voltage_scale_available, + in_voltage - voltage_scale_available, 0444, ad7192_show_scale_available, NULL, 0); static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 58420dcb406d..a4b4f8678c56 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b/drivers/staging/iio/adc/ad7280a.c @@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) } static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, - in_voltage-voltage_thresh_low_value, + in_voltage - voltage_thresh_low_value, 0644, ad7280_read_channel_config, ad7280_write_channel_config, AD7280A_CELL_UNDERVOLTAGE); static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, - in_voltage-voltage_thresh_high_value, + in_voltage - voltage_thresh_high_value, 0644, ad7280_read_channel_config, ad7280_write_channel_config,
The checkpatch.pl tool detected coding style problem: CHECK: spaces preferred around that '-' (ctx:VxV) in two files inside the adc directory. This patch will remove this problem. Signed-off-by: Slawomir Stepien <sst@poczta.fm> --- drivers/staging/iio/adc/ad7192.c | 2 +- drivers/staging/iio/adc/ad7280a.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)