| Message ID | 20181001193305.GE24866@x220.localdomain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix style problems in ad7150 driver | expand |
On 10/01/2018 09:33 PM, Slawomir Stepien wrote: > By using the pointer to channel attribute, we can now make the lines > short enough to eliminate the checkpatch.pl problem: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Slawomir Stepien <sst@poczta.fm> Hi, Thanks for the patch. This looks good. But maybe a small suggestion further improvement. > --- > drivers/staging/iio/cdc/ad7150.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index d16084d7068c..5b5b766a0405 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev, > { > int ret; > struct ad7150_chip_info *chip = iio_priv(indio_dev); > + const int *channel = &chan->channel; Instead of taking a pointer, just take the value of the channel index and use that. The generated code should be very similar but its a bit nicer to read.
On paź 04, 2018 17:21, Lars-Peter Clausen wrote: > On 10/01/2018 09:33 PM, Slawomir Stepien wrote: > > drivers/staging/iio/cdc/ad7150.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > > index d16084d7068c..5b5b766a0405 100644 > > --- a/drivers/staging/iio/cdc/ad7150.c > > +++ b/drivers/staging/iio/cdc/ad7150.c > > @@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev, > > { > > int ret; > > struct ad7150_chip_info *chip = iio_priv(indio_dev); > > + const int *channel = &chan->channel; > > Instead of taking a pointer, just take the value of the channel index and > use that. The generated code should be very similar but its a bit nicer to read. OK. I've been thinking about that for a moment, but in the end decided to go with the pointer. I don't mind the value. I'll prepare v2. Thank you.
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c index d16084d7068c..5b5b766a0405 100644 --- a/drivers/staging/iio/cdc/ad7150.c +++ b/drivers/staging/iio/cdc/ad7150.c @@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev, { int ret; struct ad7150_chip_info *chip = iio_priv(indio_dev); + const int *channel = &chan->channel; switch (mask) { case IIO_CHAN_INFO_RAW: ret = i2c_smbus_read_word_data(chip->client, - ad7150_addresses[chan->channel][0]); + ad7150_addresses[*channel][0]); if (ret < 0) return ret; *val = swab16(ret); return IIO_VAL_INT; case IIO_CHAN_INFO_AVERAGE_RAW: ret = i2c_smbus_read_word_data(chip->client, - ad7150_addresses[chan->channel][1]); + ad7150_addresses[*channel][1]); if (ret < 0) return ret; *val = swab16(ret);
By using the pointer to channel attribute, we can now make the lines short enough to eliminate the checkpatch.pl problem: CHECK: Alignment should match open parenthesis Signed-off-by: Slawomir Stepien <sst@poczta.fm> --- drivers/staging/iio/cdc/ad7150.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)