| Message ID | 20181005080444.GB2984@x220.localdomain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix style problems in ad7150 driver | expand |
On Fri, 5 Oct 2018 10:04:44 +0200 Slawomir Stepien <sst@poczta.fm> wrote: > By using the copy of channel attribute, we can now make the lines short > enough to eliminate the checkpatch.pl problem: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Slawomir Stepien <sst@poczta.fm> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index d16084d7068c..e2c70063fa0f 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev, > { > int ret; > struct ad7150_chip_info *chip = iio_priv(indio_dev); > + int channel = chan->channel; > > switch (mask) { > case IIO_CHAN_INFO_RAW: > ret = i2c_smbus_read_word_data(chip->client, > - ad7150_addresses[chan->channel][0]); > + ad7150_addresses[channel][0]); > if (ret < 0) > return ret; > *val = swab16(ret); > return IIO_VAL_INT; > case IIO_CHAN_INFO_AVERAGE_RAW: > ret = i2c_smbus_read_word_data(chip->client, > - ad7150_addresses[chan->channel][1]); > + ad7150_addresses[channel][1]); > if (ret < 0) > return ret; > *val = swab16(ret);
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c index d16084d7068c..e2c70063fa0f 100644 --- a/drivers/staging/iio/cdc/ad7150.c +++ b/drivers/staging/iio/cdc/ad7150.c @@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev, { int ret; struct ad7150_chip_info *chip = iio_priv(indio_dev); + int channel = chan->channel; switch (mask) { case IIO_CHAN_INFO_RAW: ret = i2c_smbus_read_word_data(chip->client, - ad7150_addresses[chan->channel][0]); + ad7150_addresses[channel][0]); if (ret < 0) return ret; *val = swab16(ret); return IIO_VAL_INT; case IIO_CHAN_INFO_AVERAGE_RAW: ret = i2c_smbus_read_word_data(chip->client, - ad7150_addresses[chan->channel][1]); + ad7150_addresses[channel][1]); if (ret < 0) return ret; *val = swab16(ret);
By using the copy of channel attribute, we can now make the lines short enough to eliminate the checkpatch.pl problem: CHECK: Alignment should match open parenthesis Signed-off-by: Slawomir Stepien <sst@poczta.fm> --- drivers/staging/iio/cdc/ad7150.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)