From patchwork Fri Oct 26 00:45:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656839 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7EAB9109C for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74B422C24D for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 690C22C6C8; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16FB72C652 for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726193AbeJZJUS (ORCPT ); Fri, 26 Oct 2018 05:20:18 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:41279 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbeJZJUR (ORCPT ); Fri, 26 Oct 2018 05:20:17 -0400 Received: by mail-qt1-f193.google.com with SMTP id l41-v6so12182004qtl.8 for ; Thu, 25 Oct 2018 17:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k98qfZFTnS8YJsoHEehtGRqClwouswNGYRpoM+jy0g0=; b=WfCe3OEfI5h5TiyKZsUsPEW2ZKcSFLs7dwNQWaIFKq66ADuDggB/mQcSdWhrtg+mUd nXLELbHh2LuH2DsgCXMmPv1OfsjauU70IQWSz0OnSTxjisc4ZmosHus0Nvnbt+ktMMUl pDzz/9wgNySKhry6SU46DAvPxZQMH7YF+PvOjZIuFDlbavhM79P8chxr9ZMUX5GbnFRq 4yHKooNi8IqMfMxz1I8mhHt9cYA5zo58fyVfiaSlzJJ4t3/m2BDlTp4EdNWQTw3Bv/Ci ABN8Vwi+jOKAdAZo7DqWNd2piS5ntdYePWUWi9mCDYdqThPpPUrn3pujlv67tGTWoEh3 vd6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k98qfZFTnS8YJsoHEehtGRqClwouswNGYRpoM+jy0g0=; b=qlv22K6tKw95PR/j2JgRfeqMnVmQAdafcD//H5flL/5Q2IhQX6sSGvU26EibPGp0Uu LIcd+rbJfrC8k6lJcyH9xKFqmdDiaf/Yn+564hXIN8q9+0/ST1XCllSvUwsFLbmV0bdJ EWBQaPiDL4eMtQ0pqZRyxXLjM2cXMpy25fsZl8O8OGQCvflM7EyD1N8ypwE58XiIJgBh os7ZZlg8uGPJNmQqMFQU1F5w3WG/AjbLhO0g2XEhsqXHMUYtTfcfnhVrR7Nx/HPxF/QB Iz8hl8oAlrSu/olr8e9nwawS6uP4852wOwBm93it0B3c8HpApCCE5UCPQ1ogavaSRSQ7 1gPA== X-Gm-Message-State: AGRZ1gJ6CtUgYrErN4kfIVU8LeWV157n1Qk/oRRCs1a7LovPskGVsnRp wTx0GGWQCUj3p9Nhmj8080ZeuA== X-Google-Smtp-Source: AJdET5dDxewdUwp9hl2WPeGetOqfFX7Y/rpJzmAex0gSFrFxaLYFikbhqjN5vznas7V45/6Zw8tcPQ== X-Received: by 2002:ac8:1b58:: with SMTP id p24-v6mr1364608qtk.56.1540514727014; Thu, 25 Oct 2018 17:45:27 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:26 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code Date: Thu, 25 Oct 2018 21:45:07 -0300 Message-Id: <20181026004512.31012-2-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 59586947a936..11fac9f90148 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -35,12 +35,15 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, struct ad2s90_state *st = iio_priv(indio_dev); mutex_lock(&st->lock); + ret = spi_read(st->sdev, st->rx, 2); - if (ret) - goto error_ret; + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } + *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); -error_ret: mutex_unlock(&st->lock); return IIO_VAL_INT;