From patchwork Fri Oct 26 00:45:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656841 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C77514E2 for ; Fri, 26 Oct 2018 00:45:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DCAB2C24D for ; Fri, 26 Oct 2018 00:45:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31DDF2C6C8; Fri, 26 Oct 2018 00:45:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D42A32C24D for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726111AbeJZJUU (ORCPT ); Fri, 26 Oct 2018 05:20:20 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:37314 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbeJZJUU (ORCPT ); Fri, 26 Oct 2018 05:20:20 -0400 Received: by mail-qt1-f193.google.com with SMTP id d14-v6so12209723qto.4 for ; Thu, 25 Oct 2018 17:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=rOKyx10RBKfSqOFtomhH6h1F9pCvFTdlBHfhpdYPitYnjM4w60pTYS/+VVgnO8GPh6 8lpYdCvbst88qyJ+GA0Jo6R/J3zlsy8i6cu/bmUJa1ajX/J/vx4IWlAS/FANAlcrIlqb Ok/fzUl8pNPLLHPj+XmhxzpO44mvJRSxspzN/ZzErOOw7XnS7OqukMveU5xxbyXl1aBI i6DiyO5ILy8uqyx8X7t9+bDP332/wI0uUzXllGxKQ4H9mDHzNLqMC+nudw/F3YY2R5ll HfP5f7dEGRrzdmG9J8itw9tb6Tpoz45Fk/mAy/OMfNVY2Rj9Furwd97Tpj2zquNldt8b TH+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=T1dfVzsVzB2DZohWUlmFveHBWFBoI4BXBC61IU5ImBe5NPPRA8G5zs7Du4NKUIxzCP ZEIBGqZ3H/HCLC9L8+wmdsu13vyPgnP1v/Y0OhSTAznrKJbA7IQdhN3Jppd/UADoI3az Zj7ARe3ShCdrY1HZ5+b84ByKWKmrL9nCdkzILxRz5Rcpq5PNHYFKHHXAEpTIJoTLO87G 6MMGkXU2RNTwF7c8A/3bn0zTvRIeDBX/nkmgfkF24FDQHtTOPp47bO16O1R0Iro1IJ/D 8PmTeoIRtIqSHOxifwFyNWXNtt91uRXVe2My5TaVSNTgJq0Tf6iggZqF8Ga9T1ptVbFK stQQ== X-Gm-Message-State: AGRZ1gKSwnD9udmxQJdIEfqcfiPQ/iEk5cnyZ89EdA/dYQviexsW6SoG wlq07uylFHzlq9y+oBd2bsa47w== X-Google-Smtp-Source: AJdET5dr5t3m8XMFDiKyAjILMJM7tAbXfincs/RfvmTFPw4kt2EiwgecmvjJwTGxnjfMRI3FEZKL8Q== X-Received: by 2002:aed:3b4b:: with SMTP id q11-v6mr1333973qte.229.1540514729837; Thu, 25 Oct 2018 17:45:29 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:29 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure Date: Thu, 25 Oct 2018 21:45:08 -0300 Message-Id: <20181026004512.31012-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, ad2s90_probe ignored the return code from spi_setup, not handling its possible failure. This patch makes ad2s90_probe check if the code is an error code and, if so, do the following: - Call dev_err with an appropriate error message. - Return the spi_setup's error code, aborting the execution of the rest of the function. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 11fac9f90148..d6a42e3f1bd8 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -88,7 +88,12 @@ static int ad2s90_probe(struct spi_device *spi) /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; - spi_setup(spi); + ret = spi_setup(spi); + + if (ret < 0) { + dev_err(&spi->dev, "spi_setup failed!\n"); + return ret; + } return 0; }