From patchwork Fri Oct 26 00:45:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0759A109C for ; Fri, 26 Oct 2018 00:45:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F01E02C24D for ; Fri, 26 Oct 2018 00:45:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E33052C6C8; Fri, 26 Oct 2018 00:45:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E5442C24D for ; Fri, 26 Oct 2018 00:45:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbeJZJU1 (ORCPT ); Fri, 26 Oct 2018 05:20:27 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:33685 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbeJZJU0 (ORCPT ); Fri, 26 Oct 2018 05:20:26 -0400 Received: by mail-qk1-f194.google.com with SMTP id o89so6958942qko.0 for ; Thu, 25 Oct 2018 17:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z2LHH9F5OJ0rvYdq5SDRuLDudXHduK0q/J3//KKhqZw=; b=ARIBD8TyH/vpvD17XO4fYyhxRcRMRUvKgZ4q1+hMMFlBmr61E4PU6cFWl4PtpMc6q8 9EU9JxHvK8ih9rwuQehPzA6ybyj7s+qp8MuwLs5Up4CokYEYmTEjPoSuUGh/4/cnwRdH YFkR0t+gLuemnErWZYo88pG604blVLtCZazqjmo+6So8ScvAhi29csFxtoCSsO7n+7XM nvtj4HEK3OZ8uYR7xAvznNXolK/6KAUvRZNrl/IYoj8dN5bns1170bVdBZb2pjcRmelp LyChpy8ajnNf8tBK77ITL+14kL5435LaRizJsbQ4K7OZysRWzmAexJcj1tnSd49VQCsT IlkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z2LHH9F5OJ0rvYdq5SDRuLDudXHduK0q/J3//KKhqZw=; b=YYfppXUnGT4TeUGxp+07h8PV5SWqCBV+4QfG0Zci4cyXscCU4IVAnGnQzCAlzHNf8N AN1V6CpdgKimpatOqqfSsy0eUW/is1PagY4OZmdoW+aKgqxzh2GJ83QvZqcGWuoEEY8e HwnjFy6pfVwTp4zgjqKOxc0lhlF1YJ7wE3TEaOI/Fdt0bZC5dC3BeWb8DqMVx7u0z5JK suMs4ttfBAnX3jjM4MJDG6+UdtePeuGlzLEpD5voD6GJLqB1JaDHido+z+bjNFAlWFMY Vl7wy3aVFA/b1m4HbMazJEtgkpd6ERsmsL40OSuy88nE5fjchgS4TMqUOjI54Q2xkCni Z6uQ== X-Gm-Message-State: AGRZ1gLQ/+z5GI0xoIupG9M+OMAC22JQSJouz/3STZoApr65V5I62Obf L3KvAUZ8ypvdlH3sfCCsMYXQ1g== X-Google-Smtp-Source: AJdET5cyOAOdtWKoBifkV5+tKIEVZG0aqfjFItFDEFk4bPtY2o/Muy9NaJuascOIMXxZNHldf1jHlQ== X-Received: by 2002:a37:8d06:: with SMTP id p6-v6mr1273181qkd.4.1540514735667; Thu, 25 Oct 2018 17:45:35 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:35 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 4/6] staging:iio:ad2s90: Move device registration to the end of probe Date: Thu, 25 Oct 2018 21:45:10 -0300 Message-Id: <20181026004512.31012-5-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, devm_iio_device_register was being called before the spi_setup call and the spi_device's max_speed_hz and mode assignments. This could lead to a race condition since the driver was still being set up after it was already made ready to use. To fix it, this patch moves the device registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index c20d37dc065a..b4a6a89c11b0 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -81,10 +81,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev); - if (ret) - return ret; - /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; @@ -95,7 +91,7 @@ static int ad2s90_probe(struct spi_device *spi) return ret; } - return 0; + return devm_iio_device_register(indio_dev->dev.parent, indio_dev); } static const struct spi_device_id ad2s90_id[] = {