| Message ID | 20181026023812.29720-1-martin@martingkelly.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/4] iio: magnetometer: add clarifying comment | expand |
Hi Martin, All the series [v2 / 4 patches] looks good to me. Thanks Denis -----Original Message----- From: Martin Kelly <martin@martingkelly.com> Sent: Thursday, October 25, 2018 7:38 PM To: linux-iio@vger.kernel.org; devicetree@vger.kernel.org Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>; Denis CIOCCA <denis.ciocca@st.com>; Jonathan Cameron <jic23@kernel.org>; Rob Herring <robh+dt@kernel.org>; Martin Kelly <martin@martingkelly.com> Subject: [PATCH v2 1/4] iio: magnetometer: add clarifying comment From: Martin Kelly <martin@martingkelly.com> Add a comment clarifying better when to use <device_name> vs <device_name>-magn in compatibility strings. Signed-off-by: Martin Kelly <martin@martingkelly.com> --- drivers/iio/magnetometer/st_magn_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/magnetometer/st_magn_spi.c b/drivers/iio/magnetometer/st_magn_spi.c index 7b7cd08fcc32..15bb09267098 100644 --- a/drivers/iio/magnetometer/st_magn_spi.c +++ b/drivers/iio/magnetometer/st_magn_spi.c @@ -23,6 +23,8 @@ * For new single-chip sensors use <device_name> as compatible string. * For old single-chip devices keep <device_name>-magn to maintain * compatibility + * For multi-chip devices, use <device_name>-magn to distinguish which + * capability is being used */ static const struct of_device_id st_magn_of_match[] = { { -- 2.11.0
On Fri, 26 Oct 2018 18:24:41 +0000 Denis CIOCCA <denis.ciocca@st.com> wrote: > Hi Martin, > > All the series [v2 / 4 patches] looks good to me. Thanks > Formal Acked-by / Reviewed-by? Thanks, Jonathan > Denis > > > -----Original Message----- > From: Martin Kelly <martin@martingkelly.com> > Sent: Thursday, October 25, 2018 7:38 PM > To: linux-iio@vger.kernel.org; devicetree@vger.kernel.org > Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>; Denis CIOCCA <denis.ciocca@st.com>; Jonathan Cameron <jic23@kernel.org>; Rob Herring <robh+dt@kernel.org>; Martin Kelly <martin@martingkelly.com> > Subject: [PATCH v2 1/4] iio: magnetometer: add clarifying comment > > From: Martin Kelly <martin@martingkelly.com> > > Add a comment clarifying better when to use <device_name> vs <device_name>-magn in compatibility strings. > > Signed-off-by: Martin Kelly <martin@martingkelly.com> > --- > drivers/iio/magnetometer/st_magn_spi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/magnetometer/st_magn_spi.c b/drivers/iio/magnetometer/st_magn_spi.c > index 7b7cd08fcc32..15bb09267098 100644 > --- a/drivers/iio/magnetometer/st_magn_spi.c > +++ b/drivers/iio/magnetometer/st_magn_spi.c > @@ -23,6 +23,8 @@ > * For new single-chip sensors use <device_name> as compatible string. > * For old single-chip devices keep <device_name>-magn to maintain > * compatibility > + * For multi-chip devices, use <device_name>-magn to distinguish which > + * capability is being used > */ > static const struct of_device_id st_magn_of_match[] = { > { > -- > 2.11.0 >
On Thu, 25 Oct 2018 19:38:09 -0700 Martin Kelly <martin@martingkelly.com> wrote: > From: Martin Kelly <martin@martingkelly.com> > > Add a comment clarifying better when to use <device_name> vs > <device_name>-magn in compatibility strings. > > Signed-off-by: Martin Kelly <martin@martingkelly.com> Applied to the togreg branch of iio.git and pushed out as testing. I'll ideally added acks from Dennis and Rob for relevant patches before I push it out as non rebasing which will probably be next weekend given my current habits. Thanks, Jonathan > --- > drivers/iio/magnetometer/st_magn_spi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/magnetometer/st_magn_spi.c b/drivers/iio/magnetometer/st_magn_spi.c > index 7b7cd08fcc32..15bb09267098 100644 > --- a/drivers/iio/magnetometer/st_magn_spi.c > +++ b/drivers/iio/magnetometer/st_magn_spi.c > @@ -23,6 +23,8 @@ > * For new single-chip sensors use <device_name> as compatible string. > * For old single-chip devices keep <device_name>-magn to maintain > * compatibility > + * For multi-chip devices, use <device_name>-magn to distinguish which > + * capability is being used > */ > static const struct of_device_id st_magn_of_match[] = { > {
diff --git a/drivers/iio/magnetometer/st_magn_spi.c b/drivers/iio/magnetometer/st_magn_spi.c index 7b7cd08fcc32..15bb09267098 100644 --- a/drivers/iio/magnetometer/st_magn_spi.c +++ b/drivers/iio/magnetometer/st_magn_spi.c @@ -23,6 +23,8 @@ * For new single-chip sensors use <device_name> as compatible string. * For old single-chip devices keep <device_name>-magn to maintain * compatibility + * For multi-chip devices, use <device_name>-magn to distinguish which + * capability is being used */ static const struct of_device_id st_magn_of_match[] = { {