From patchwork Sat Oct 27 02:00:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10658025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42B1E14DE for ; Sat, 27 Oct 2018 02:00:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 353A62C79A for ; Sat, 27 Oct 2018 02:00:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 29A202C7A1; Sat, 27 Oct 2018 02:00:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C5BA2C79A for ; Sat, 27 Oct 2018 02:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbeJ0KkC (ORCPT ); Sat, 27 Oct 2018 06:40:02 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:47011 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbeJ0KkB (ORCPT ); Sat, 27 Oct 2018 06:40:01 -0400 Received: by mail-qk1-f196.google.com with SMTP id q1so129053qkf.13 for ; Fri, 26 Oct 2018 19:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=WjbK4B6Pz9n82ZrdDfd6PM5GbCp+QQyg3yNP3mE7mKzlOXjeN844EOEYIK2yahjQ0o mVp8ZHWSiKqLhFU9dnqEusVrxdF5+JSSC859jT7UY984FUY0tflownWmlZ2cmc8CGs+S t5xXcLBtcYq4EXaVJKSzsERb14VLzX0FNpZm06WX2ReOxgJAS8HI744ZwIUCV4hU3YMZ Kn6aBih4w7SM2pRK7K3QsFWq5UKIh+IaTLkDvcXJ6o/iYJlFE2B0bogytJBkp9fhmehr NX5h0px7aJS0V+aFJ7EZpleD7VB0oBRmUpu2ebvwHrP4hrlF8Z2W8ht/UmcwhwFYFgH5 nsCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=t20Fp8haw6RF8/2UgKXWCCI/cdJnmVIpFLg2VuTKn91eDv5V5Dh/n0FSC5fWouufmt RD5QktcrZKpDTQUazcNr9h/mzMfn63tvG/8mx7anqovkj/x+AR4uf6cgvUw+dQ7n7vRu 8OdZ9sQt2Bw9D7QXofm42IXDZDt2CYTQy6mg7sZUK0F95GYM5yXMqGREPHojBfs5t3oa ixOI3C2hSHqccW7/MyPmQIEqHSlPTcHswyCckOFsUqexrLn2JFLic3+b2OnKtiO0oPLu jygFMkcIWmmhAvHoXTmhZrhqKkJhCmCO/xbSMBg6Y+Z91t8TIK6DvHrgixhLtU1A9If9 WJ2w== X-Gm-Message-State: AGRZ1gLXEwJKpKQFnVlFd5kBMxXP4OzwNjcSkn5O+gbLbxOleAMF4+8s lh5QQvaBkxH/nq0HucuXRuX1sQ== X-Google-Smtp-Source: AJdET5fQuEouxoTq1ebTp9DugDk3pG9h6vIhcvOj+9AFlURyWW6ARC4U0cY76QYXWd4bS/Cds7iOMA== X-Received: by 2002:a37:fa8:: with SMTP id 40mr5265581qkp.48.1540605641110; Fri, 26 Oct 2018 19:00:41 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id h67-v6sm8499777qkf.32.2018.10.26.19.00.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:00:40 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure Date: Fri, 26 Oct 2018 23:00:01 -0300 Message-Id: <20181027020005.3140-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, ad2s90_probe ignored the return code from spi_setup, not handling its possible failure. This patch makes ad2s90_probe check if the code is an error code and, if so, do the following: - Call dev_err with an appropriate error message. - Return the spi_setup's error code, aborting the execution of the rest of the function. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 11fac9f90148..d6a42e3f1bd8 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -88,7 +88,12 @@ static int ad2s90_probe(struct spi_device *spi) /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; - spi_setup(spi); + ret = spi_setup(spi); + + if (ret < 0) { + dev_err(&spi->dev, "spi_setup failed!\n"); + return ret; + } return 0; }