From patchwork Sat Nov 3 22:49:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 68F4317D4 for ; Sat, 3 Nov 2018 22:50:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CCBC29AC7 for ; Sat, 3 Nov 2018 22:50:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 50B9A29AD3; Sat, 3 Nov 2018 22:50:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 65EC629ACD for ; Sat, 3 Nov 2018 22:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728599AbeKDICt (ORCPT ); Sun, 4 Nov 2018 03:02:49 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:45752 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbeKDICt (ORCPT ); Sun, 4 Nov 2018 03:02:49 -0500 Received: by mail-qk1-f194.google.com with SMTP id d135so8909991qkc.12 for ; Sat, 03 Nov 2018 15:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9WTEEyu2PskGPSxUGKrtAjHaKSrp/L3vMKzLiu3cbGg=; b=r5r9RgfVxE21mp07NnNDnSYmc6exBER3fT82vmtGer3obqxsAA1Pm94nglHJIq1MTw D46w5ApH2CDU3qCxWI59fOQlx6o3zCD1dGNYYABvJAkmd6jqhcDKg6HV7zYL79FtRjku Z8hYvcgpBi8k5pgOc4rr+ypvrLXmcvLCPnvX5BhaJbgpMeZurei5OxmY/oiur6wU9GhO cOPcsM32d+/lbcFWlVV0137YVxI6RbHnFOIHrCyPnT637BI1mI6nkAJidTCQzy19elCa M2TWwPksokgvHpDirk8UylaOmkGVXIqa5IaPaGqLoiuRDQ2rbWnMyfdwCBoRVKKLvLHC +mSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9WTEEyu2PskGPSxUGKrtAjHaKSrp/L3vMKzLiu3cbGg=; b=QwdYmZZcb1WsmAJsIrxKMCSk5sUwT9BfNbt9KFBRvIvm9E0gOOK1FZVXxzdzcHy05T pjPXSBUK9d4ijD6nLXBQBFhQhjXDG5PMbNBryyda0q2+9imJS9nea2MFXuUlYM5TMy+9 ff9/i3zca7LxdK/oolq4l/Mma1fDMFZR6RlLKQHHgw/l85sQxOdFh3lVRDBSDFjN5zns TPMzjYT6OxCQcHgqX+5A/G6/2DHyLIEoJkjazezmhXEvL/c/+2jL1R0v2C6vZbzmY0IS xs7sN2VmNcyHmtGftf9AVmZPJCnwXzR0+vP66Ifr/0Ssj9v+b1HQPtIhQu2eofSxxNnj uvyQ== X-Gm-Message-State: AGRZ1gKNT383aJVRGJcjz+7kyb4EbeSpRC76MSAl3wlEmtBiI5pJC3kd 3HIpICsS4COV37F67ENx+ZdT9g== X-Google-Smtp-Source: AJdET5clEuKXvSPDzKcVrQLCl7ErwcEaA6KpYThvCN+Im97tnxYe3mwSgdb9nxWFJV5HjQGo0Mmwkw== X-Received: by 2002:a37:a3c6:: with SMTP id m189mr15557224qke.173.1541285408393; Sat, 03 Nov 2018 15:50:08 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:07 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v3 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code Date: Sat, 3 Nov 2018 19:49:43 -0300 Message-Id: <20181103224948.31014-2-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 59586947a936..ba55de29ef36 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -36,11 +36,12 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, mutex_lock(&st->lock); ret = spi_read(st->sdev, st->rx, 2); - if (ret) - goto error_ret; + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); -error_ret: mutex_unlock(&st->lock); return IIO_VAL_INT;