From patchwork Sat Nov 3 22:49:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8CE6514E2 for ; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E7C829AC7 for ; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7260229AD3; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D63F29AC7 for ; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728743AbeKDIDA (ORCPT ); Sun, 4 Nov 2018 03:03:00 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:43787 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728779AbeKDIC7 (ORCPT ); Sun, 4 Nov 2018 03:02:59 -0500 Received: by mail-qk1-f195.google.com with SMTP id r71so8936392qkr.10 for ; Sat, 03 Nov 2018 15:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GD4vVE0HPom8l9DS59ZCy1DA4DKNmflT3aSJsaYUcgA=; b=GUubobDbcf/zDkYhIxxdggdX5hJks+0xN50pfmTtNVPHJ/FsxiA37fzyP7ZUQFQXKZ XzKqgVBBVFS6abh6HRkRZYMjN7nr+U6nWU7NcwP/lkaojZlhWmiQ4P33MfOqGCjMVTZA 70ZnLGQg90J7uWn5E9GM4/A7KLkwxnnrDTvKOXckH3UqGO3uQKdw4Q6U/tHi1Y7efaTh jr78V2ovjPRAN4ecvL1Vfs0UwZZHkZuM7m1OwxPiXu1k9VdT07nIWAImtGDVUvVI1n9G BeAyPXxh+gzhcFDkiyj6lpI29neTAcVbx+aeKVWA8IPl+ugesdmkbUPHjJ7FmtH4VAcf +wkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GD4vVE0HPom8l9DS59ZCy1DA4DKNmflT3aSJsaYUcgA=; b=JU9jATc4oP2EABbBtBSrUPn1FWs5419zGyhM2BpiAkbg4wtvxCZjqReS4Pbg5/gEHP HrzznovLbdBkoWSAyK9R+1MlobataOuQEVS7InrXuhuysHJ+2BGoSqVPOXNCcKx311ZR hJxr4UflZhElyR/Kgq8Tb6goTukFxroH5vvm5dXkQMbeBFFIHBNNEMqk1Ycg4JQU0+Qf R+CJ8UhM0+45y8Sy+ryJlFxfd0uuTzBDQn2IZy6M/Hxili3eRRnKeKI77Rr5HKQoPkVr rBxF07duyKP65io9S1tdfrXcom9SW4wyvu0RUhSyvzToRFme0APquoMsbBfYrpO45YTc nGig== X-Gm-Message-State: AGRZ1gI76C70K+ASWlqhbobVzpCAJuU+80UNly2SVyElKRa75FVmQTJS W0B5iG9PGuTr/ksfE2rrBmzr3Q== X-Google-Smtp-Source: AJdET5emOQoEEYsu17VDqPH9pxzz2d8As5AujJn8zwW1Qxm3/MB7tl+pB1q14J/EA6PzkIgkSqhjkw== X-Received: by 2002:ac8:6104:: with SMTP id a4-v6mr10478328qtm.350.1541285418902; Sat, 03 Nov 2018 15:50:18 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:18 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v3 4/6] staging:iio:ad2s90: Move device registration to the end of probe Date: Sat, 3 Nov 2018 19:49:46 -0300 Message-Id: <20181103224948.31014-5-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, devm_iio_device_register was being called before the spi_setup call and the spi_device's max_speed_hz and mode assignments. This could lead to a race condition since the driver was still being set up after it was already made ready to use. To fix it, this patch moves the device registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 54ad85bd9dc6..8f79cccf4814 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -79,10 +79,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev); - if (ret) - return ret; - /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; @@ -93,7 +89,7 @@ static int ad2s90_probe(struct spi_device *spi) return ret; } - return 0; + return devm_iio_device_register(indio_dev->dev.parent, indio_dev); } static const struct spi_device_id ad2s90_id[] = {