From patchwork Fri Nov 9 22:00:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10676583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1FC57175A for ; Fri, 9 Nov 2018 22:01:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10EC02F222 for ; Fri, 9 Nov 2018 22:01:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00A622F1FA; Fri, 9 Nov 2018 22:01:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D5632F1FA for ; Fri, 9 Nov 2018 22:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728490AbeKJHnw (ORCPT ); Sat, 10 Nov 2018 02:43:52 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:36967 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728492AbeKJHnv (ORCPT ); Sat, 10 Nov 2018 02:43:51 -0500 Received: by mail-qk1-f196.google.com with SMTP id 131so4349169qkd.4 for ; Fri, 09 Nov 2018 14:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PypJCBItqAHhZtAV1pEt8q1mShtNp5yrZpvXlh8zIpA=; b=n8ECNe8XttM1lMFHrmoGegTYTbaS/vHXlJjOm1fEylbHqjTWqs2UwCRP7hLlqVsTGL XWvdnmUkTSSk/atBSubz482ZwKky/kKjn3LK75TPs2cnx7OrMd8R5akuNKs7sSxKa2Eg I6I6YZz1Eff1YYCq2A6INCqQbMg4siz2lOT1qwwa2w0AbhkoP9BQ3ihF5w/fYucmdw+i 2SISTRl6myfUHjG/0I9fAt8ip2A+QNPo1UNerhShDrbXuu/icrK+F7y6wM+Zw4afMEa2 LjLt/7JvvEdjZrmqtQpKk4jdfjTZguwBlPE6vqWu2UcySAyv9uSlyCNWVReLuYKFkhpZ vYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PypJCBItqAHhZtAV1pEt8q1mShtNp5yrZpvXlh8zIpA=; b=YsfrYKmubcLAr2/dfTv7XIEo5eqkqrPIZLC0mbdO6+c3bb90CV/hscdHxmEko5/S0r azYAVIJMdyGZsh8SXulnkYuEcnujSx79WGiE2ewC0Bdx9VrC/RHcRDsVvcob2xwT0LWY sNlfUIMRSa2YTUOkquUD4NTDKo069VHcnDMxywubp0bXzQlzp/ElmXfUpx13h96nVz8o ixZmcp6B6Kswnjwbfcy3A1Cq9Jhf96p3pMQ10pr8wjaKfAnYUUR4qdhnWBlhesb3LaIy QwqVWtCuJT9P7PVQBl8aAXT/plcLebxNR1FbbmR4tJooi1ZvSQkr3bc++8+hD9kFpxsI 9rzA== X-Gm-Message-State: AGRZ1gIlBF39dRRM37lIc7PXPS0B9ZPCRZ7mOkNtbUrzkyv7B9AkJqBi 5hAEAoZtIOsvUuUiQejgNehPoQ== X-Google-Smtp-Source: AJdET5eaLOI9WM3k8hO+ymflInkgXSQpXJ9eoBHh9r2G+92J4eCOErwGMcUAzuR/sQASkrWUFjHraQ== X-Received: by 2002:aed:384a:: with SMTP id j68mr10289681qte.171.1541800880829; Fri, 09 Nov 2018 14:01:20 -0800 (PST) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id k6sm6082723qtk.41.2018.11.09.14.01.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Nov 2018 14:01:20 -0800 (PST) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , Rob Herring , Mark Rutland Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandru Ardelean , kernel-usp@googlegroups.com, victorcolombo@gmail.com Subject: [PATCH 2/6] staging:iio:ad2s90: Remove spi setup that should be done via dt Date: Fri, 9 Nov 2018 20:00:40 -0200 Message-Id: <20181109220044.24843-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181109220044.24843-1-matheus.bernardino@usp.br> References: <20181109220044.24843-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ad2s90 driver currently sets some spi settings (max_speed_hz and mode) at ad2s90_probe. This should, instead, be handled via device tree. This patch removes these configurations from the probe function. Note: The way in which the mentioned spi settings need to be specified on the ad2s90's node of a device tree will be documented in the future patch "dt-bindings:iio:resolver: Add docs for ad2s90". Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index ff32ca76ca00..95c118c48400 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -77,7 +77,6 @@ static int ad2s90_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad2s90_state *st; - int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) @@ -94,16 +93,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - /* need 600ns between CS and the first falling edge of SCLK */ - spi->max_speed_hz = 830000; - spi->mode = SPI_MODE_3; - ret = spi_setup(spi); - - if (ret < 0) { - dev_err(&spi->dev, "spi_setup failed!\n"); - return ret; - } - return devm_iio_device_register(indio_dev->dev.parent, indio_dev); }