| Message ID | 20181116224907.24376-1-shreeya.patel23498@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove platform data and introduce DT bindings | expand |
On Sat, 17 Nov 2018 04:19:07 +0530 Shreeya Patel <shreeya.patel23498@gmail.com> wrote: > adt7316_i2c_read function nowhere sets the data field. > It is necessary to have an appropriate value for it. > Hence, assign the value stored in 'ret' variable to data field. > > Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com> I have amended the description slightly to make it clear this is a fix and that it has been broken so long we aren't that bothered about it going into stable! Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/addac/adt7316-i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio/addac/adt7316-i2c.c > index f66dd3ebbab1..856bcfa60c6c 100644 > --- a/drivers/staging/iio/addac/adt7316-i2c.c > +++ b/drivers/staging/iio/addac/adt7316-i2c.c > @@ -35,6 +35,8 @@ static int adt7316_i2c_read(void *client, u8 reg, u8 *data) > return ret; > } > > + *data = ret; > + > return 0; > } >
diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio/addac/adt7316-i2c.c index f66dd3ebbab1..856bcfa60c6c 100644 --- a/drivers/staging/iio/addac/adt7316-i2c.c +++ b/drivers/staging/iio/addac/adt7316-i2c.c @@ -35,6 +35,8 @@ static int adt7316_i2c_read(void *client, u8 reg, u8 *data) return ret; } + *data = ret; + return 0; }
adt7316_i2c_read function nowhere sets the data field. It is necessary to have an appropriate value for it. Hence, assign the value stored in 'ret' variable to data field. Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com> --- drivers/staging/iio/addac/adt7316-i2c.c | 2 ++ 1 file changed, 2 insertions(+)