From patchwork Sun Nov 18 04:25:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10687683 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B4761109C for ; Sun, 18 Nov 2018 04:26:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A447E29F29 for ; Sun, 18 Nov 2018 04:26:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 98A1B29F61; Sun, 18 Nov 2018 04:26:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B536D29F29 for ; Sun, 18 Nov 2018 04:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725876AbeKROpV (ORCPT ); Sun, 18 Nov 2018 09:45:21 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:40880 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726916AbeKROpU (ORCPT ); Sun, 18 Nov 2018 09:45:20 -0500 Received: by mail-qk1-f195.google.com with SMTP id y16so43866069qki.7 for ; Sat, 17 Nov 2018 20:26:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AQMJAzyixzk0/1WSmVNMs8fwNy6KbazheSZxWxsLE1Q=; b=IglfmGaTcc71ngiuUY41D+tnc+EvGiwidh4C3kcgtK1eS2GyctTL3DU2/+MQkTu5Ua TrOYIgrs+5PVbmDZg5vPGVBCj03LjTvUD8UElhGtfL/t08tboq7e++X8BAF6ab1SKrLn MT6jODnIyXtc4FrJowQX/TBwM0Od/hRTWWB7R0In1/mG+ic64ZFaW1oo/5Ots8Mbky9J 5wv90c2Y273iM7eWICtQUzKmXY13sT88YKY2pTAIRWnPEczx2Uzk9rzvj6jJzkQWeVZU VdKxE5dihCj5DguC8cQHjpzYQTyl+q/0RYhgHM60NQeaYdZIi0VCVBV4NF99YSi98DrZ 1iaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AQMJAzyixzk0/1WSmVNMs8fwNy6KbazheSZxWxsLE1Q=; b=jPIOYs2hAlnrNwYjwUZ/cY8akpUOjNlNZQAyNhcY7ZrZfbiyiaN3V+k7ZGO9PNmDR4 hxb+nlPX7U+99u8WNlRihnC5FTvn3MIyzi2ST+HR7IcfJBg0Wyup24V2t/aAXb0vEkFf mPRqaX67B3EpQNtsyYwO7403YdADnNORRGVIQatwOs+E/f2493kNumR6DArBcMR1Z1lR zWLAbsr8Hwshlxz9+5HiIh9aPLZ2OprhbJ2BVxgm249yp4MzzT51wEjU83pRQwDp24S+ UW0a/LJvGVhP7eZxjKK4fEJtnhT8kDUR/4w6bApcTbVLI8286JKo+9A9thLUogaaL8LQ zRkw== X-Gm-Message-State: AGRZ1gKomv1q8n0Eh8290eFi/aY+amYmm1+cyK8+GEFgosguOt2dDvq4 lYomp4vcYmiEdZ9mLNCkdFVj0A== X-Google-Smtp-Source: AJdET5cJKIsOMW/SSS/EjI4ctTvTOPvYfU2/3uxDjcl82XPyZ2hZWe0DrD14DJ602UzbMSs3JfqvYA== X-Received: by 2002:ac8:34cb:: with SMTP id x11mr16053740qtb.115.1542515179321; Sat, 17 Nov 2018 20:26:19 -0800 (PST) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id b6sm16112350qtq.29.2018.11.17.20.26.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Nov 2018 20:26:18 -0800 (PST) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , Rob Herring , Mark Rutland Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandru Ardelean , kernel-usp@googlegroups.com, victorcolombo@gmail.com Subject: [PATCH v2 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt Date: Sun, 18 Nov 2018 02:25:35 -0200 Message-Id: <20181118042540.12697-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181118042540.12697-1-matheus.bernardino@usp.br> References: <20181118042540.12697-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ad2s90 driver currently sets some spi settings (max_speed_hz and mode) at ad2s90_probe. Since the maximum frequency is a required element in DT binding for spi slave devices and because the spi mode for the device can be either (0,0) or (1,1), these settings should be handled via device tree, not in the driver's code. This patch removes them from the probe function. Note: The way in which the mentioned spi settings need to be specified on the ad2s90's node of a device tree will be documented in the future patch "dt-bindings:iio:resolver: Add docs for ad2s90". Signed-off-by: Matheus Tavares --- Changes in v2: - Rewritten patch message to better explain why the code snippet in question should be removed. drivers/staging/iio/resolver/ad2s90.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 6ffbac66b837..913d6fad2d4d 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -77,7 +77,6 @@ static int ad2s90_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad2s90_state *st; - int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) @@ -94,16 +93,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - /* need 600ns between CS and the first falling edge of SCLK */ - spi->max_speed_hz = 830000; - spi->mode = SPI_MODE_3; - ret = spi_setup(spi); - - if (ret < 0) { - dev_err(&spi->dev, "spi_setup failed!\n"); - return ret; - } - return devm_iio_device_register(indio_dev->dev.parent, indio_dev); }