| Message ID | 20190603193433.6394-2-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] iio: imx7d_adc: Remove unneeded error message | expand |
On Mon, 3 Jun 2019 16:34:31 -0300 Fabio Estevam <festevam@gmail.com> wrote: > Since the input clock is always 24MHz, there is no need for storing > this value into a variable. > > Use a definition instead, which is more appropriate in this case. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. thanks, Jonathan > --- > drivers/iio/adc/imx7d_adc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c > index 23c7b0ee945f..bffc172e7635 100644 > --- a/drivers/iio/adc/imx7d_adc.c > +++ b/drivers/iio/adc/imx7d_adc.c > @@ -78,6 +78,7 @@ > #define IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT 0xf0000 > > #define IMX7D_ADC_TIMEOUT msecs_to_jiffies(100) > +#define IMX7D_ADC_INPUT_CLK 24000000 > > enum imx7d_adc_clk_pre_div { > IMX7D_ADC_ANALOG_CLK_PRE_DIV_4, > @@ -272,13 +273,11 @@ static void imx7d_adc_channel_set(struct imx7d_adc *info) > > static u32 imx7d_adc_get_sample_rate(struct imx7d_adc *info) > { > - /* input clock is always 24MHz */ > - u32 input_clk = 24000000; > u32 analogue_core_clk; > u32 core_time_unit = info->adc_feature.core_time_unit; > u32 tmp; > > - analogue_core_clk = input_clk / info->pre_div_num; > + analogue_core_clk = IMX7D_ADC_INPUT_CLK / info->pre_div_num; > tmp = (core_time_unit + 1) * 6; > > return analogue_core_clk / tmp;
diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c index 23c7b0ee945f..bffc172e7635 100644 --- a/drivers/iio/adc/imx7d_adc.c +++ b/drivers/iio/adc/imx7d_adc.c @@ -78,6 +78,7 @@ #define IMX7D_REG_ADC_INT_STATUS_CHANNEL_CONV_TIME_OUT 0xf0000 #define IMX7D_ADC_TIMEOUT msecs_to_jiffies(100) +#define IMX7D_ADC_INPUT_CLK 24000000 enum imx7d_adc_clk_pre_div { IMX7D_ADC_ANALOG_CLK_PRE_DIV_4, @@ -272,13 +273,11 @@ static void imx7d_adc_channel_set(struct imx7d_adc *info) static u32 imx7d_adc_get_sample_rate(struct imx7d_adc *info) { - /* input clock is always 24MHz */ - u32 input_clk = 24000000; u32 analogue_core_clk; u32 core_time_unit = info->adc_feature.core_time_unit; u32 tmp; - analogue_core_clk = input_clk / info->pre_div_num; + analogue_core_clk = IMX7D_ADC_INPUT_CLK / info->pre_div_num; tmp = (core_time_unit + 1) * 6; return analogue_core_clk / tmp;
Since the input clock is always 24MHz, there is no need for storing this value into a variable. Use a definition instead, which is more appropriate in this case. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/iio/adc/imx7d_adc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)