| Message ID | 20190715081514.81129-4-sean@geanix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/6] iio: imu: st_lsm6dsx: move interrupt thread to core | expand |
> This add ways for the SoC to wake from accelerometer wake events. > > In the suspend function we skip disabling the sensor if wakeup-source > and events are activated. > [...] > EXPORT_SYMBOL(st_lsm6dsx_probe); > @@ -1372,6 +1376,12 @@ static int __maybe_unused st_lsm6dsx_suspend(struct device *dev) > if (!hw->iio_devs[i]) > continue; > > + if (device_may_wakeup(dev) && (i == ST_LSM6DSX_ID_ACC)) { unnecessary brackets > + /* Enable wake from IRQ */ > + enable_irq_wake(hw->irq); > + continue; > + } I think we need to move this after enable_mask check, dont' we? > + > sensor = iio_priv(hw->iio_devs[i]); > if (!(hw->enable_mask & BIT(sensor->id))) > continue; > @@ -1404,6 +1414,11 @@ static int __maybe_unused st_lsm6dsx_resume(struct device *dev) > if (!hw->iio_devs[i]) > continue; > > + if (device_may_wakeup(dev) && (i == ST_LSM6DSX_ID_ACC)) { unnecessary brackets > + disable_irq_wake(hw->irq); > + continue; > + } > + > sensor = iio_priv(hw->iio_devs[i]); > if (!(hw->suspend_mask & BIT(sensor->id))) > continue; > -- > 2.22.0 >
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index 6decb0846f1a..fc450eeb9870 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -1358,6 +1358,10 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id, return err; } + if (dev->of_node) + if (of_property_read_bool(dev->of_node, "wakeup-source")) + device_init_wakeup(dev, true); + return 0; } EXPORT_SYMBOL(st_lsm6dsx_probe); @@ -1372,6 +1376,12 @@ static int __maybe_unused st_lsm6dsx_suspend(struct device *dev) if (!hw->iio_devs[i]) continue; + if (device_may_wakeup(dev) && (i == ST_LSM6DSX_ID_ACC)) { + /* Enable wake from IRQ */ + enable_irq_wake(hw->irq); + continue; + } + sensor = iio_priv(hw->iio_devs[i]); if (!(hw->enable_mask & BIT(sensor->id))) continue; @@ -1404,6 +1414,11 @@ static int __maybe_unused st_lsm6dsx_resume(struct device *dev) if (!hw->iio_devs[i]) continue; + if (device_may_wakeup(dev) && (i == ST_LSM6DSX_ID_ACC)) { + disable_irq_wake(hw->irq); + continue; + } + sensor = iio_priv(hw->iio_devs[i]); if (!(hw->suspend_mask & BIT(sensor->id))) continue;
This add ways for the SoC to wake from accelerometer wake events. In the suspend function we skip disabling the sensor if wakeup-source and events are activated. Signed-off-by: Sean Nyekjaer <sean@geanix.com> --- Changes since v1: * none, as the call to st_lsm6dsx_flush_fifo will put the fifo in bypass mode. drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)