| Message ID | 20190813193101.26867-1-rodrigorsdc@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] staging: iio: accel: adis16240: Improve readability on write_raw function | expand |
On Tue, 2019-08-13 at 16:31 -0300, Rodrigo Ribeiro wrote: > [External] > > Replace shift and minus operation by GENMASK macro and remove the local > variables used to store intermediate data. > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Rodrigo Ribeiro Carvalho <rodrigorsdc@gmail.com> > --- > v2: > - Leave switch statement instead of replace by if statement > drivers/staging/iio/accel/adis16240.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > index 62f4b3b1b457..82099db4bf0c 100644 > --- a/drivers/staging/iio/accel/adis16240.c > +++ b/drivers/staging/iio/accel/adis16240.c > @@ -309,15 +309,12 @@ static int adis16240_write_raw(struct iio_dev *indio_dev, > long mask) > { > struct adis *st = iio_priv(indio_dev); > - int bits = 10; > - s16 val16; > u8 addr; > > switch (mask) { > case IIO_CHAN_INFO_CALIBBIAS: > - val16 = val & ((1 << bits) - 1); > addr = adis16240_addresses[chan->scan_index][0]; > - return adis_write_reg_16(st, addr, val16); > + return adis_write_reg_16(st, addr, val & GENMASK(9, 0)); > } > return -EINVAL; > }
On Wed, 14 Aug 2019 06:56:18 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Tue, 2019-08-13 at 16:31 -0300, Rodrigo Ribeiro wrote: > > [External] > > > > Replace shift and minus operation by GENMASK macro and remove the local > > variables used to store intermediate data. > > > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > > Signed-off-by: Rodrigo Ribeiro Carvalho <rodrigorsdc@gmail.com> > > --- > > v2: > > - Leave switch statement instead of replace by if statement > > drivers/staging/iio/accel/adis16240.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > > index 62f4b3b1b457..82099db4bf0c 100644 > > --- a/drivers/staging/iio/accel/adis16240.c > > +++ b/drivers/staging/iio/accel/adis16240.c > > @@ -309,15 +309,12 @@ static int adis16240_write_raw(struct iio_dev *indio_dev, > > long mask) > > { > > struct adis *st = iio_priv(indio_dev); > > - int bits = 10; > > - s16 val16; > > u8 addr; > > > > switch (mask) { > > case IIO_CHAN_INFO_CALIBBIAS: > > - val16 = val & ((1 << bits) - 1); > > addr = adis16240_addresses[chan->scan_index][0]; > > - return adis_write_reg_16(st, addr, val16); > > + return adis_write_reg_16(st, addr, val & GENMASK(9, 0)); > > } > > return -EINVAL; > > }
diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c index 62f4b3b1b457..82099db4bf0c 100644 --- a/drivers/staging/iio/accel/adis16240.c +++ b/drivers/staging/iio/accel/adis16240.c @@ -309,15 +309,12 @@ static int adis16240_write_raw(struct iio_dev *indio_dev, long mask) { struct adis *st = iio_priv(indio_dev); - int bits = 10; - s16 val16; u8 addr; switch (mask) { case IIO_CHAN_INFO_CALIBBIAS: - val16 = val & ((1 << bits) - 1); addr = adis16240_addresses[chan->scan_index][0]; - return adis_write_reg_16(st, addr, val16); + return adis_write_reg_16(st, addr, val & GENMASK(9, 0)); } return -EINVAL; }
Replace shift and minus operation by GENMASK macro and remove the local variables used to store intermediate data. Signed-off-by: Rodrigo Ribeiro Carvalho <rodrigorsdc@gmail.com> --- v2: - Leave switch statement instead of replace by if statement drivers/staging/iio/accel/adis16240.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)