| Message ID | 20190815074339.32380-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [iio-next] iio: light: noa1305: fix missing break in a switch statement | expand |
On Thu, 15 Aug 2019 08:43:39 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > There is a missing break for the NOA1305_INTEGR_TIME_400MS case, > fix it by adding it in. > > Addresses-Coverity: ("Missing break in switch") > Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Hi Colin Fix already on it's way in. Was also caught by 0-day. Thanks, Jonathan > --- > drivers/iio/light/noa1305.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c > index 7b859ae1044d..5ebfbc52f541 100644 > --- a/drivers/iio/light/noa1305.c > +++ b/drivers/iio/light/noa1305.c > @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2) > case NOA1305_INTEGR_TIME_400MS: > *val = 100; > *val2 = 77 * 4; > + break; > case NOA1305_INTEGR_TIME_200MS: > *val = 100; > *val2 = 77 * 2;
diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c index 7b859ae1044d..5ebfbc52f541 100644 --- a/drivers/iio/light/noa1305.c +++ b/drivers/iio/light/noa1305.c @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2) case NOA1305_INTEGR_TIME_400MS: *val = 100; *val2 = 77 * 4; + break; case NOA1305_INTEGR_TIME_200MS: *val = 100; *val2 = 77 * 2;