diff mbox series

iio: adc: ingenic: Use devm_platform_ioremap_resource

Message ID 20191013152716.1830911-1-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series iio: adc: ingenic: Use devm_platform_ioremap_resource | expand

Commit Message

Jonathan Cameron Oct. 13, 2019, 3:27 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Replaces local boilerplate.  Identified by coccinelle.
CHECK   drivers/iio/adc/ingenic-adc.c
drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use devm_platform_ioremap_resource for adc -> base

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Artur Rojek <contact@artur-rojek.eu>
---
 drivers/iio/adc/ingenic-adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Alexandru Ardelean Nov. 4, 2019, 3:16 p.m. UTC | #1 
On Sun, 2019-10-13 at 16:27 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Replaces local boilerplate.  Identified by coccinelle.
> CHECK   drivers/iio/adc/ingenic-adc.c
> drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use
> devm_platform_ioremap_resource for adc -> base
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Artur Rojek <contact@artur-rojek.eu>
> ---
>  drivers/iio/adc/ingenic-adc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-
> adc.c
> index 7a53c2f8d438..39c0a609fc94 100644
> --- a/drivers/iio/adc/ingenic-adc.c
> +++ b/drivers/iio/adc/ingenic-adc.c
> @@ -428,7 +428,6 @@ static int ingenic_adc_probe(struct platform_device
> *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct iio_dev *iio_dev;
>  	struct ingenic_adc *adc;
> -	struct resource *mem_base;
>  	const struct ingenic_adc_soc_data *soc_data;
>  	int ret;
>  
> @@ -445,8 +444,7 @@ static int ingenic_adc_probe(struct platform_device
> *pdev)
>  	mutex_init(&adc->aux_lock);
>  	adc->soc_data = soc_data;
>  
> -	mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	adc->base = devm_ioremap_resource(dev, mem_base);
> +	adc->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(adc->base))
>  		return PTR_ERR(adc->base);
>
Jonathan Cameron Nov. 9, 2019, 12:20 p.m. UTC | #2 
On Mon, 4 Nov 2019 15:16:14 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 16:27 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Replaces local boilerplate.  Identified by coccinelle.
> > CHECK   drivers/iio/adc/ingenic-adc.c
> > drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use
> > devm_platform_ioremap_resource for adc -> base
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,

Thanks,

Jonathan

> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Artur Rojek <contact@artur-rojek.eu>
> > ---
> >  drivers/iio/adc/ingenic-adc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-
> > adc.c
> > index 7a53c2f8d438..39c0a609fc94 100644
> > --- a/drivers/iio/adc/ingenic-adc.c
> > +++ b/drivers/iio/adc/ingenic-adc.c
> > @@ -428,7 +428,6 @@ static int ingenic_adc_probe(struct platform_device
> > *pdev)
> >  	struct device *dev = &pdev->dev;
> >  	struct iio_dev *iio_dev;
> >  	struct ingenic_adc *adc;
> > -	struct resource *mem_base;
> >  	const struct ingenic_adc_soc_data *soc_data;
> >  	int ret;
> >  
> > @@ -445,8 +444,7 @@ static int ingenic_adc_probe(struct platform_device
> > *pdev)
> >  	mutex_init(&adc->aux_lock);
> >  	adc->soc_data = soc_data;
> >  
> > -	mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	adc->base = devm_ioremap_resource(dev, mem_base);
> > +	adc->base = devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(adc->base))
> >  		return PTR_ERR(adc->base);
> >
diff mbox series

Patch

diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
index 7a53c2f8d438..39c0a609fc94 100644
--- a/drivers/iio/adc/ingenic-adc.c
+++ b/drivers/iio/adc/ingenic-adc.c
@@ -428,7 +428,6 @@  static int ingenic_adc_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct iio_dev *iio_dev;
 	struct ingenic_adc *adc;
-	struct resource *mem_base;
 	const struct ingenic_adc_soc_data *soc_data;
 	int ret;
 
@@ -445,8 +444,7 @@  static int ingenic_adc_probe(struct platform_device *pdev)
 	mutex_init(&adc->aux_lock);
 	adc->soc_data = soc_data;
 
-	mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	adc->base = devm_ioremap_resource(dev, mem_base);
+	adc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(adc->base))
 		return PTR_ERR(adc->base);