| Message ID | 20191013154427.1853794-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: npcm: use devm_platform_ioremap_resource | expand |
On Sun, 2019-10-13 at 16:44 +0100, jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Reduces local boilerplate code. > Suggested by coccinelle via coccicheck. > > CHECK drivers/iio/adc/npcm_adc.c > drivers/iio/adc/npcm_adc.c:200:1-11: WARNING: Use > devm_platform_ioremap_resource for info -> regs > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Tomer Maimon <tmaimon77@gmail.com> > --- > drivers/iio/adc/npcm_adc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c > index 910f3585fa54..a6170a37ebe8 100644 > --- a/drivers/iio/adc/npcm_adc.c > +++ b/drivers/iio/adc/npcm_adc.c > @@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device > *pdev) > int irq; > u32 div; > u32 reg_con; > - struct resource *res; > struct npcm_adc *info; > struct iio_dev *indio_dev; > struct device *dev = &pdev->dev; > @@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device > *pdev) > > info->dev = &pdev->dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - info->regs = devm_ioremap_resource(&pdev->dev, res); > + info->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(info->regs)) > return PTR_ERR(info->regs); >
On Mon, 4 Nov 2019 15:17:08 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Sun, 2019-10-13 at 16:44 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Reduces local boilerplate code. > > Suggested by coccinelle via coccicheck. > > > > CHECK drivers/iio/adc/npcm_adc.c > > drivers/iio/adc/npcm_adc.c:200:1-11: WARNING: Use > > devm_platform_ioremap_resource for info -> regs > > > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied, Thanks, Jonathan > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Tomer Maimon <tmaimon77@gmail.com> > > --- > > drivers/iio/adc/npcm_adc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c > > index 910f3585fa54..a6170a37ebe8 100644 > > --- a/drivers/iio/adc/npcm_adc.c > > +++ b/drivers/iio/adc/npcm_adc.c > > @@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device > > *pdev) > > int irq; > > u32 div; > > u32 reg_con; > > - struct resource *res; > > struct npcm_adc *info; > > struct iio_dev *indio_dev; > > struct device *dev = &pdev->dev; > > @@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device > > *pdev) > > > > info->dev = &pdev->dev; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - info->regs = devm_ioremap_resource(&pdev->dev, res); > > + info->regs = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(info->regs)) > > return PTR_ERR(info->regs); > >
diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c index 910f3585fa54..a6170a37ebe8 100644 --- a/drivers/iio/adc/npcm_adc.c +++ b/drivers/iio/adc/npcm_adc.c @@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device *pdev) int irq; u32 div; u32 reg_con; - struct resource *res; struct npcm_adc *info; struct iio_dev *indio_dev; struct device *dev = &pdev->dev; @@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device *pdev) info->dev = &pdev->dev; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - info->regs = devm_ioremap_resource(&pdev->dev, res); + info->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(info->regs)) return PTR_ERR(info->regs);