diff mbox series

iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler.

Message ID 20191013162133.1999362-1-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler. | expand

Commit Message

Jonathan Cameron Oct. 13, 2019, 4:21 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Coccinelle noticed:
CHECK   drivers/iio/adc/cpcap-adc.c
drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

As far as I can see this is a simple case of it should be specified
but isn't.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Tony Lindgren <tony@atomide.com>
---
 drivers/iio/adc/cpcap-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren Oct. 16, 2019, 5:24 p.m. UTC | #1 
* jic23@kernel.org <jic23@kernel.org> [191013 16:24]:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Coccinelle noticed:
> CHECK   drivers/iio/adc/cpcap-adc.c
> drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> 
> As far as I can see this is a simple case of it should be specified
> but isn't.

Acked-by: Tony Lindgren <tony@atomide.com>
Jonathan Cameron Oct. 18, 2019, 7:03 p.m. UTC | #2 
On Wed, 16 Oct 2019 10:24:47 -0700
Tony Lindgren <tony@atomide.com> wrote:

> * jic23@kernel.org <jic23@kernel.org> [191013 16:24]:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Coccinelle noticed:
> > CHECK   drivers/iio/adc/cpcap-adc.c
> > drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> > 
> > As far as I can see this is a simple case of it should be specified
> > but isn't.  
> 
> Acked-by: Tony Lindgren <tony@atomide.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobulders to play with it

Thanks,

Jonathan
diff mbox series

Patch

diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c
index 2d616cafe75f..5086a337f4c9 100644
--- a/drivers/iio/adc/cpcap-adc.c
+++ b/drivers/iio/adc/cpcap-adc.c
@@ -1008,7 +1008,7 @@  static int cpcap_adc_probe(struct platform_device *pdev)
 
 	error = devm_request_threaded_irq(&pdev->dev, ddata->irq, NULL,
 					  cpcap_adc_irq_thread,
-					  IRQF_TRIGGER_NONE,
+					  IRQF_TRIGGER_NONE | IRQF_ONESHOT,
 					  "cpcap-adc", indio_dev);
 	if (error) {
 		dev_err(&pdev->dev, "could not get irq: %i\n",