| Message ID | 20191013173852.2265620-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: light: adux1020: Drop an unwanted semicolon. | expand |
On Sun, 13 Oct 2019 18:38:52 +0100 jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Suggested by coccinelle > > CHECK drivers/iio/light/adux1020.c > drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> 0-day sent me the same patch as well. I've rolled it into the original code as that was still on testing only which was getting rebased anyway. Thanks, Jonathan > --- > drivers/iio/light/adux1020.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c > index 830e5e95d58f..b07797ac10d7 100644 > --- a/drivers/iio/light/adux1020.c > +++ b/drivers/iio/light/adux1020.c > @@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data) > if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) { > dev_err(&client->dev, "invalid chip id 0x%04x\n", val); > return -ENODEV; > - }; > + } > > dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val); >
Hi Jonathan, On Tue, Oct 15, 2019 at 09:12:15PM +0100, Jonathan Cameron wrote: > On Sun, 13 Oct 2019 18:38:52 +0100 > jic23@kernel.org wrote: > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Suggested by coccinelle > > > > CHECK drivers/iio/light/adux1020.c > > drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > 0-day sent me the same patch as well. > > I've rolled it into the original code as that was still on > testing only which was getting rebased anyway. > Makes sense! Thanks, Mani > Thanks, > > Jonathan > > > --- > > drivers/iio/light/adux1020.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c > > index 830e5e95d58f..b07797ac10d7 100644 > > --- a/drivers/iio/light/adux1020.c > > +++ b/drivers/iio/light/adux1020.c > > @@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data) > > if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) { > > dev_err(&client->dev, "invalid chip id 0x%04x\n", val); > > return -ENODEV; > > - }; > > + } > > > > dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val); > > >
diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c index 830e5e95d58f..b07797ac10d7 100644 --- a/drivers/iio/light/adux1020.c +++ b/drivers/iio/light/adux1020.c @@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data) if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) { dev_err(&client->dev, "invalid chip id 0x%04x\n", val); return -ENODEV; - }; + } dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);