| Message ID | 20191127130729.18511-1-olivier.moysan@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] iio: adc: stm32-dfsdm: fix single conversion | expand |
On 11/27/19 2:07 PM, Olivier Moysan wrote: > Apply data formatting to single conversion, > as this is already done in continuous and trigger modes. > > Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode") > > Signed-off-by: Olivier Moysan <olivier.moysan@st.com> Hi Olivier, Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com> Thanks, Fabrice > --- > changes in version 2: > - correct title > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index e493242c266e..0339ecdd06bd 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev, > > stm32_dfsdm_stop_conv(adc); > > + stm32_dfsdm_process_data(adc, res); > + > stop_dfsdm: > stm32_dfsdm_stop_dfsdm(adc->dfsdm); > >
Hi Jonathan, all, Kind reminder on this patch. Regards Olivier On 11/27/19 2:07 PM, Olivier Moysan wrote: > Apply data formatting to single conversion, > as this is already done in continuous and trigger modes. > > Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode") > > Signed-off-by: Olivier Moysan <olivier.moysan@st.com> > --- > changes in version 2: > - correct title > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index e493242c266e..0339ecdd06bd 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev, > > stm32_dfsdm_stop_conv(adc); > > + stm32_dfsdm_process_data(adc, res); > + > stop_dfsdm: > stm32_dfsdm_stop_dfsdm(adc->dfsdm); >
On Fri, 10 Jan 2020 10:05:47 +0000 Olivier MOYSAN <olivier.moysan@st.com> wrote: > Hi Jonathan, all, > > Kind reminder on this patch. Gah. Sorry .I marked it to reply then forgot to actually come back and do so. Thanks for the reminder. Given timing I'll apply this to the togreg branch of iio.git and get it lined up for the merge window. Marked it for stable so it should quickly get applied to stable as appropriate after that. Sorry for the delay. Thanks, Jonathan > Regards > Olivier > > On 11/27/19 2:07 PM, Olivier Moysan wrote: > > Apply data formatting to single conversion, > > as this is already done in continuous and trigger modes. > > > > Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode") > > > > Signed-off-by: Olivier Moysan <olivier.moysan@st.com> > > --- > > changes in version 2: > > - correct title > > --- > > drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > > index e493242c266e..0339ecdd06bd 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > > @@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev, > > > > stm32_dfsdm_stop_conv(adc); > > > > + stm32_dfsdm_process_data(adc, res); > > + > > stop_dfsdm: > > stm32_dfsdm_stop_dfsdm(adc->dfsdm); > >
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c index e493242c266e..0339ecdd06bd 100644 --- a/drivers/iio/adc/stm32-dfsdm-adc.c +++ b/drivers/iio/adc/stm32-dfsdm-adc.c @@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev, stm32_dfsdm_stop_conv(adc); + stm32_dfsdm_process_data(adc, res); + stop_dfsdm: stm32_dfsdm_stop_dfsdm(adc->dfsdm);
Apply data formatting to single conversion, as this is already done in continuous and trigger modes. Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode") Signed-off-by: Olivier Moysan <olivier.moysan@st.com> --- changes in version 2: - correct title --- drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++ 1 file changed, 2 insertions(+)