| Message ID | 20191216173853.75797-6-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/9] iio: light: st_uvis25: Drop unneeded header inclusion | expand |
On Mon, 16 Dec 2019 19:38:50 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Since we put static variable to a header file it's copied to each module > that includes the header. But not all of them are actually used it. > > Mark default_press_pdata with __maybe_unused to calm a compiler down: > > In file included from drivers/iio/pressure/st_pressure_spi.c:18: > drivers/iio/pressure/st_pressure.h:40:46: warning: ‘default_press_pdata’ defined but not used [-Wunused-const-variable=] > 40 | static const struct st_sensors_platform_data default_press_pdata = { > | ^~~~~~~~~~~~~~~~~~~ > ... > Applied. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/iio/pressure/st_pressure.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/pressure/st_pressure.h b/drivers/iio/pressure/st_pressure.h > index c2e47a6c3118..5c746ff6087e 100644 > --- a/drivers/iio/pressure/st_pressure.h > +++ b/drivers/iio/pressure/st_pressure.h > @@ -37,7 +37,7 @@ enum st_press_type { > * struct st_sensors_platform_data - default press platform data > * @drdy_int_pin: default press DRDY is available on INT1 pin. > */ > -static const struct st_sensors_platform_data default_press_pdata = { > +static __maybe_unused const struct st_sensors_platform_data default_press_pdata = { > .drdy_int_pin = 1, > }; >
diff --git a/drivers/iio/pressure/st_pressure.h b/drivers/iio/pressure/st_pressure.h index c2e47a6c3118..5c746ff6087e 100644 --- a/drivers/iio/pressure/st_pressure.h +++ b/drivers/iio/pressure/st_pressure.h @@ -37,7 +37,7 @@ enum st_press_type { * struct st_sensors_platform_data - default press platform data * @drdy_int_pin: default press DRDY is available on INT1 pin. */ -static const struct st_sensors_platform_data default_press_pdata = { +static __maybe_unused const struct st_sensors_platform_data default_press_pdata = { .drdy_int_pin = 1, };
Since we put static variable to a header file it's copied to each module that includes the header. But not all of them are actually used it. Mark default_press_pdata with __maybe_unused to calm a compiler down: In file included from drivers/iio/pressure/st_pressure_spi.c:18: drivers/iio/pressure/st_pressure.h:40:46: warning: ‘default_press_pdata’ defined but not used [-Wunused-const-variable=] 40 | static const struct st_sensors_platform_data default_press_pdata = { | ^~~~~~~~~~~~~~~~~~~ ... Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/iio/pressure/st_pressure.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)