| Message ID | 20200324080309.12171-1-mike.looijmans@topic.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v5,1/2] dt-bindings: iio: accel: Add bmi088 accelerometer bindings | expand |
On Tue, 24 Mar 2020 09:03:07 +0100 Mike Looijmans <mike.looijmans@topic.nl> wrote: > This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, > the accelerometer part. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> Ah. For some reason I missed there was a v5. Comments on the v4 binding. Jonathan > --- > v2: convert to yaml format > v3..v4: - > v5: submit together with driver code as patch series > .../bindings/iio/accel/bosch,bmi088.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > new file mode 100644 > index 000000000000..715f79c3b2a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bosch BMI088 IMU accelerometer part > + > +maintainers: > + - Mike Looijmans <mike.looijmans@topic.nl> > + > +description: | > + Acceleration part of the IMU sensor with an SPI interface > + > + Specifications about the sensor can be found at: > + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf > + > +properties: > + compatible: > + enum: > + - bosch,bmi088_accel > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + spi { > + bmi088_accel@1 { > + compatible = "bosch,bmi088_accel"; > + reg = <1>; > + spi-max-frequency = <10000000>; > + }; > + };
On Tue, 24 Mar 2020 09:03:07 +0100, Mike Looijmans wrote: > This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, > the accelerometer part. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > v2: convert to yaml format > v3..v4: - > v5: submit together with driver code as patch series > .../bindings/iio/accel/bosch,bmi088.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml: while scanning a simple key in "<unicode string>", line 32, column 3 could not find expected ':' in "<unicode string>", line 38, column 3 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/iio/accel/bosch,bmi088.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/iio/accel/bosch,bmi088.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... warning: no schema found in file: Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml: ignoring, error parsing file Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1260498 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml new file mode 100644 index 000000000000..715f79c3b2a9 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bosch BMI088 IMU accelerometer part + +maintainers: + - Mike Looijmans <mike.looijmans@topic.nl> + +description: | + Acceleration part of the IMU sensor with an SPI interface + + Specifications about the sensor can be found at: + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf + +properties: + compatible: + enum: + - bosch,bmi088_accel + + reg: + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + spi { + bmi088_accel@1 { + compatible = "bosch,bmi088_accel"; + reg = <1>; + spi-max-frequency = <10000000>; + }; + };
This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, the accelerometer part. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- v2: convert to yaml format v3..v4: - v5: submit together with driver code as patch series .../bindings/iio/accel/bosch,bmi088.yaml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml