| Message ID | 20200506230324.139241-2-gwendal@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: cros_ec: Add support for RGB light sensor | expand |
On Wed, 6 May 2020 16:03:22 -0700 Gwendal Grignou <gwendal@chromium.org> wrote: Illuminance in the title. Plus I'm still arguing these aren't illuminance values. The Y value is illuminance but X and Z definitely aren't. RGB needs to stick to intensity - like the other existing RGB sensors. Gah. XYZ and IIO is a mess. I suppose we could introduce a new type and have in_illumiance_raw in_chromacity_x_raw in_chromacity_z_raw but chances of anyone understanding what we are on about without reading wikipedia is low... Sigh. Unless someone else chips in, I'm inclined to be lazy and rely on documentation to let in_illuminance_x,y,z be defined as being cie xyz color space measurements. It seems slighlty preferable to defining another type for these, though I suspect I'll regret this comment when some adds cie lab which was always my favourite colour space :) > Define 2 spaces for defining color coming from color sensors: > RGB and XYZ: Both are in lux. > RGB is the raw output from sensors (Red, Green and Blue channels), in > addition to the existing clear channel (C). > The RGBC vector goes through a matrix transformation to produce the XYZ > vector. Y is illumincance, and XY caries the chromaticity information. > The matrix is model specific, as the color sensor can be behing a glass > that can filter some wavelengths. > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > --- > New in v2. > > Documentation/ABI/testing/sysfs-bus-iio | 27 +++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index d3e53a6d8331b..256db6e63a25e 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -1309,6 +1309,33 @@ Description: > Illuminance measurement, units after application of scale > and offset are lux. > > +What: /sys/.../iio:deviceX/in_illuminance_red_raw > +What: /sys/.../iio:deviceX/in_illuminance_green_raw > +What: /sys/.../iio:deviceX/in_illuminance_blue_raw > +KernelVersion: 5.7 > +Contact: linux-iio@vger.kernel.org > +Description: > + Illuminance measuremed in red, green or blue channels, units > + after application of scale and offset are lux. No they aren't. Units are some magic intensity at some magic wavelength. > + > +What: /sys/.../iio:deviceX/in_illuminance_x_raw > +What: /sys/.../iio:deviceX/in_illuminance_y_raw > +What: /sys/.../iio:deviceX/in_illuminance_z_raw > +KernelVersion: 5.7 > +Contact: linux-iio@vger.kernel.org > +Description: > + lluminance measured in the CIE 1931 color space (XYZ). > + in_illuminance_y_raw is a measure of the brightness, and is > + identical in_illuminance_raw. That is fair enough. > + in_illuminance_x_raw and in_illuminance_z_raw carry chromacity > + information. > + in_illuminance_x,y,z_raw are be obtained from the sensor color > + channels using color matching functions that may be device > + specific. > + Units after application of scale and offset are lux. True for Y, not for X and Z which don't have 'units' as such. > + The measurments can be used to represent colors in the CIE > + xyY color space XYZ > + > What: /sys/.../iio:deviceX/in_intensityY_raw > What: /sys/.../iio:deviceX/in_intensityY_ir_raw > What: /sys/.../iio:deviceX/in_intensityY_both_raw
On Fri, May 8, 2020 at 8:16 AM Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > > On Wed, 6 May 2020 16:03:22 -0700 > Gwendal Grignou <gwendal@chromium.org> wrote: > > Illuminance in the title. Plus I'm still arguing these > aren't illuminance values. > > The Y value is illuminance but X and Z definitely aren't. > RGB needs to stick to intensity - like the other existing > RGB sensors. > > Gah. XYZ and IIO is a mess. > > I suppose we could introduce a new type and have > in_illumiance_raw > in_chromacity_x_raw > in_chromacity_z_raw but chances of anyone understanding what we > are on about without reading wikipedia is low... > > Sigh. Unless someone else chips in, I'm inclined to be lazy and rely > on documentation to let in_illuminance_x,y,z be defined as being > cie xyz color space measurements. > > It seems slighlty preferable to defining another type for these, > though I suspect I'll regret this comment when some adds > cie lab which was always my favourite colour space :) > > > > > Define 2 spaces for defining color coming from color sensors: > > RGB and XYZ: Both are in lux. > > RGB is the raw output from sensors (Red, Green and Blue channels), in > > addition to the existing clear channel (C). > > > The RGBC vector goes through a matrix transformation to produce the XYZ > > vector. Y is illumincance, and XY caries the chromaticity information. > > The matrix is model specific, as the color sensor can be behing a glass > > that can filter some wavelengths. > > > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > > --- > > New in v2. > > > > Documentation/ABI/testing/sysfs-bus-iio | 27 +++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > > index d3e53a6d8331b..256db6e63a25e 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-iio > > +++ b/Documentation/ABI/testing/sysfs-bus-iio > > @@ -1309,6 +1309,33 @@ Description: > > Illuminance measurement, units after application of scale > > and offset are lux. > > > > +What: /sys/.../iio:deviceX/in_illuminance_red_raw > > +What: /sys/.../iio:deviceX/in_illuminance_green_raw > > +What: /sys/.../iio:deviceX/in_illuminance_blue_raw > > +KernelVersion: 5.7 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Illuminance measuremed in red, green or blue channels, units > > + after application of scale and offset are lux. > > No they aren't. Units are some magic intensity at some magic wavelength. > > > + > > +What: /sys/.../iio:deviceX/in_illuminance_x_raw > > +What: /sys/.../iio:deviceX/in_illuminance_y_raw > > +What: /sys/.../iio:deviceX/in_illuminance_z_raw > > +KernelVersion: 5.7 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + lluminance measured in the CIE 1931 color space (XYZ). > > + in_illuminance_y_raw is a measure of the brightness, and is > > + identical in_illuminance_raw. > > That is fair enough. > > > + in_illuminance_x_raw and in_illuminance_z_raw carry chromacity > > + information. > > + in_illuminance_x,y,z_raw are be obtained from the sensor color > > + channels using color matching functions that may be device > > + specific. > > + Units after application of scale and offset are lux. > > True for Y, not for X and Z which don't have 'units' as such. Indeed,I have difficulty mapping what comes from the sensor after adapting to an acceptable universal entity. The goal of the sensor is to measure the ambient correlated color temperature (CCT), based on the x and y of the CIE xyY color space. Given x and y are defined as x = X / (X + Y +Z) and y = X / (X + Y + Z), X, Y and Z must have the same units. CCT(x,y) is computed in user space, for example using this approximation (https://en.wikipedia.org/wiki/Color_temperature#Approximation). Gwendal. > > > + The measurments can be used to represent colors in the CIE > > + xyY color space > > XYZ > > > + > > What: /sys/.../iio:deviceX/in_intensityY_raw > > What: /sys/.../iio:deviceX/in_intensityY_ir_raw > > What: /sys/.../iio:deviceX/in_intensityY_both_raw > >
On Mon, 11 May 2020 21:10:40 -0700 Gwendal Grignou <gwendal@chromium.org> wrote: > On Fri, May 8, 2020 at 8:16 AM Jonathan Cameron > <Jonathan.Cameron@huawei.com> wrote: > > > > On Wed, 6 May 2020 16:03:22 -0700 > > Gwendal Grignou <gwendal@chromium.org> wrote: > > > > Illuminance in the title. Plus I'm still arguing these > > aren't illuminance values. > > > > The Y value is illuminance but X and Z definitely aren't. > > RGB needs to stick to intensity - like the other existing > > RGB sensors. > > > > Gah. XYZ and IIO is a mess. > > > > I suppose we could introduce a new type and have > > in_illumiance_raw > > in_chromacity_x_raw > > in_chromacity_z_raw but chances of anyone understanding what we > > are on about without reading wikipedia is low... > > > > Sigh. Unless someone else chips in, I'm inclined to be lazy and rely > > on documentation to let in_illuminance_x,y,z be defined as being > > cie xyz color space measurements. > > > > It seems slighlty preferable to defining another type for these, > > though I suspect I'll regret this comment when some adds > > cie lab which was always my favourite colour space :) > > > > > > > > > Define 2 spaces for defining color coming from color sensors: > > > RGB and XYZ: Both are in lux. > > > RGB is the raw output from sensors (Red, Green and Blue channels), in > > > addition to the existing clear channel (C). > > > > > The RGBC vector goes through a matrix transformation to produce the XYZ > > > vector. Y is illumincance, and XY caries the chromaticity information. > > > The matrix is model specific, as the color sensor can be behing a glass > > > that can filter some wavelengths. > > > > > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > > > --- > > > New in v2. > > > > > > Documentation/ABI/testing/sysfs-bus-iio | 27 +++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > > > index d3e53a6d8331b..256db6e63a25e 100644 > > > --- a/Documentation/ABI/testing/sysfs-bus-iio > > > +++ b/Documentation/ABI/testing/sysfs-bus-iio > > > @@ -1309,6 +1309,33 @@ Description: > > > Illuminance measurement, units after application of scale > > > and offset are lux. > > > > > > +What: /sys/.../iio:deviceX/in_illuminance_red_raw > > > +What: /sys/.../iio:deviceX/in_illuminance_green_raw > > > +What: /sys/.../iio:deviceX/in_illuminance_blue_raw > > > +KernelVersion: 5.7 > > > +Contact: linux-iio@vger.kernel.org > > > +Description: > > > + Illuminance measuremed in red, green or blue channels, units > > > + after application of scale and offset are lux. > > > > No they aren't. Units are some magic intensity at some magic wavelength. > > > > > + > > > +What: /sys/.../iio:deviceX/in_illuminance_x_raw > > > +What: /sys/.../iio:deviceX/in_illuminance_y_raw > > > +What: /sys/.../iio:deviceX/in_illuminance_z_raw > > > +KernelVersion: 5.7 > > > +Contact: linux-iio@vger.kernel.org > > > +Description: > > > + lluminance measured in the CIE 1931 color space (XYZ). > > > + in_illuminance_y_raw is a measure of the brightness, and is > > > + identical in_illuminance_raw. > > > > That is fair enough. > > > > > + in_illuminance_x_raw and in_illuminance_z_raw carry chromacity > > > + information. > > > + in_illuminance_x,y,z_raw are be obtained from the sensor color > > > + channels using color matching functions that may be device > > > + specific. > > > + Units after application of scale and offset are lux. > > > > True for Y, not for X and Z which don't have 'units' as such. > Indeed,I have difficulty mapping what comes from the sensor after > adapting to an acceptable universal entity. > > The goal of the sensor is to measure the ambient correlated color > temperature (CCT), based on the x and y of the CIE xyY color space. > Given x and y are defined as x = X / (X + Y +Z) and y = X / (X + Y + > Z), X, Y and Z must have the same units. The issue here is that illuminance is an unusual thing. To go for an analogy. It's like measuring the volume of something at a particular temperature. However, it's only defined at that temperature. You can divide it by other volumes at other temperatures and get all sorts of interesting quantities and much like volume the indeed have the same units, but that unit is not lux (which is unit of illuminance). The reason being illuminance is like defining volume at 0 degree centigrade. Illuminance is only defined for that particular set of frequencies and is not defined otherwise. If we'd called our light input something other than illuminance - say 'in_light_raw' then we could play fast and loose with units perhaps but we didn't. We deliberately used intensity to represent all light measurements other than the one specific one that is illuminance. So we should stick to intensity really which was chosen specifically to 'not carry' the weird characteristics that illuminance has. It deliberately makes no statement about frequency sensitivity etc. In a past life I did a lot of work machine vision so am familiar with most of the standard colour spaces and what they were trying to do when defining them. Personally always like CieLAB because you can basically use it to get rid of shadows :) Maths to compute it is however fairly crazy. Jonathan > > CCT(x,y) is computed in user space, for example using this > approximation (https://en.wikipedia.org/wiki/Color_temperature#Approximation). > > Gwendal. > > > > > > > + The measurments can be used to represent colors in the CIE > > > + xyY color space > > > > XYZ > > > > > + > > > What: /sys/.../iio:deviceX/in_intensityY_raw > > > What: /sys/.../iio:deviceX/in_intensityY_ir_raw > > > What: /sys/.../iio:deviceX/in_intensityY_both_raw > > > >
diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio index d3e53a6d8331b..256db6e63a25e 100644 --- a/Documentation/ABI/testing/sysfs-bus-iio +++ b/Documentation/ABI/testing/sysfs-bus-iio @@ -1309,6 +1309,33 @@ Description: Illuminance measurement, units after application of scale and offset are lux. +What: /sys/.../iio:deviceX/in_illuminance_red_raw +What: /sys/.../iio:deviceX/in_illuminance_green_raw +What: /sys/.../iio:deviceX/in_illuminance_blue_raw +KernelVersion: 5.7 +Contact: linux-iio@vger.kernel.org +Description: + Illuminance measuremed in red, green or blue channels, units + after application of scale and offset are lux. + +What: /sys/.../iio:deviceX/in_illuminance_x_raw +What: /sys/.../iio:deviceX/in_illuminance_y_raw +What: /sys/.../iio:deviceX/in_illuminance_z_raw +KernelVersion: 5.7 +Contact: linux-iio@vger.kernel.org +Description: + lluminance measured in the CIE 1931 color space (XYZ). + in_illuminance_y_raw is a measure of the brightness, and is + identical in_illuminance_raw. + in_illuminance_x_raw and in_illuminance_z_raw carry chromacity + information. + in_illuminance_x,y,z_raw are be obtained from the sensor color + channels using color matching functions that may be device + specific. + Units after application of scale and offset are lux. + The measurments can be used to represent colors in the CIE + xyY color space + What: /sys/.../iio:deviceX/in_intensityY_raw What: /sys/.../iio:deviceX/in_intensityY_ir_raw What: /sys/.../iio:deviceX/in_intensityY_both_raw
Define 2 spaces for defining color coming from color sensors: RGB and XYZ: Both are in lux. RGB is the raw output from sensors (Red, Green and Blue channels), in addition to the existing clear channel (C). The RGBC vector goes through a matrix transformation to produce the XYZ vector. Y is illumincance, and XY caries the chromaticity information. The matrix is model specific, as the color sensor can be behing a glass that can filter some wavelengths. Signed-off-by: Gwendal Grignou <gwendal@chromium.org> --- New in v2. Documentation/ABI/testing/sysfs-bus-iio | 27 +++++++++++++++++++++++++ 1 file changed, 27 insertions(+)