| Message ID | 20200518133645.19127-3-jonathan.albrieux@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: magnetometer: ak8975: Add gpio reset support | expand |
On Mon, May 18, 2020 at 3:37 PM Jonathan Albrieux <jonathan.albrieux@gmail.com> wrote: > + reset-gpio: > + description: an optional pin needed for AK09911 to set the reset state This kind of properties should always be plural, so reset-gpios please. Yours, Linus Walleij
On Mon, May 25, 2020 at 10:43:35AM +0200, Linus Walleij wrote: > On Mon, May 18, 2020 at 3:37 PM Jonathan Albrieux > <jonathan.albrieux@gmail.com> wrote: > > > + reset-gpio: > > + description: an optional pin needed for AK09911 to set the reset state > > This kind of properties should always be plural, so > reset-gpios please. > > Yours, > Linus Walleij Thank you, will include this change in current patch version I'm working on. Best regards, Jonathan Albrieux
diff --git a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml index 86e3efa693a8..a82c0ff5d098 100644 --- a/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml +++ b/Documentation/devicetree/bindings/iio/magnetometer/ak8975.yaml @@ -37,6 +37,9 @@ properties: mount-matrix: description: an optional 3x3 mounting rotation matrix + reset-gpio: + description: an optional pin needed for AK09911 to set the reset state + required: - compatible - reg @@ -53,6 +56,7 @@ examples: reg = <0x0c>; gpios = <&gpj0 7 0>; vdd-supply = <&ldo_3v3_gnss>; + reset-gpio = <&msmgpio 111 1>; mount-matrix = "-0.984807753012208", /* x0 */ "0", /* y0 */ "-0.173648177666930", /* z0 */
Add reset-gpio support. AK09911 has a reset gpio to handle register's reset. If reset gpio is set to low it will trigger the reset. AK09911 datasheed says that if not used reset pin should be connected to VID and this patch emulates this situation Without setting it to high on ak8975_power_on driver's probe fails on ak8975_who_i_am while checking for device identity for AK09911 chip Signed-off-by: Jonathan Albrieux <jonathan.albrieux@gmail.com> --- .../devicetree/bindings/iio/magnetometer/ak8975.yaml | 4 ++++ 1 file changed, 4 insertions(+)