From patchwork Mon May 25 17:06:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 11569077 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A29941392 for ; Mon, 25 May 2020 17:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81C9C207D8 for ; Mon, 25 May 2020 17:09:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590426542; bh=CxYHx5n4rZeuGiT5E8ZQEM9kqOu7HPZ4zfAaZ1Sivc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hH24fX7dwZGTmykcIby6uINKwQFMtaoJ73+1N4j/kCuD/hu/1Hd4EoR0TzI/OaWRH IKrapv5gUxJ91bt3q+lwvih5BLuVYeF73nap6wz6bS8wbIX8YJ/H9Hdo6fIUGaGzum kKpXCzRSO9EIbXaf6DVp7tBOnSzCetlzqxzZmE2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389203AbgEYRJC (ORCPT ); Mon, 25 May 2020 13:09:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:42536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388812AbgEYRJC (ORCPT ); Mon, 25 May 2020 13:09:02 -0400 Received: from localhost.localdomain (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FF4820723; Mon, 25 May 2020 17:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590426541; bh=CxYHx5n4rZeuGiT5E8ZQEM9kqOu7HPZ4zfAaZ1Sivc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y3TJkDWJnJ206dnU47zAsyfh0NGPktZrQXW9/hM4WGCXYsky+7EV/0o+N6GMFVsGJ zp4+hDd0jISARg11OrbR0lzzMnbtCsZ8hIyLtoHC0KB23tk5iaP8RyzOn3sPXId7Gd z0Sn2k9TxJ/t7mYWKCt1rc+8QklVO0dI51FNbBoE= From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler Subject: [PATCH 01/25] iio:light:si1145: Fix timestamp alignment and prevent data leak. Date: Mon, 25 May 2020 18:06:04 +0100 Message-Id: <20200525170628.503283-2-jic23@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200525170628.503283-1-jic23@kernel.org> References: <20200525170628.503283-1-jic23@kernel.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Jonathan Cameron One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses a 24 byte array of smaller elements on the stack. As Lars also noted this anti pattern can involve a leak of data to userspace and that indeed can happen here. We close both issues by moving to a suitable array in the iio_priv() data with alignment explicitly requested. This data is allocated with kzalloc so no data can leak appart from previous readings. Fixes: ac45e57f1590 ("iio: light: Add driver for Silabs si1132, si1141/2/3 and si1145/6/7 ambient light, uv index and proximity sensors") Reported-by: Lars-Peter Clausen Signed-off-by: Jonathan Cameron Cc: Peter Meerwald-Stadler --- drivers/iio/light/si1145.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c index 0476c2bc8138..aa93c6d38043 100644 --- a/drivers/iio/light/si1145.c +++ b/drivers/iio/light/si1145.c @@ -179,6 +179,8 @@ struct si1145_data { bool autonomous; struct iio_trigger *trig; int meas_rate; + /* Ensure timestamp will be naturally aligned if present */ + u8 buffer[24] __aligned(8); }; /** @@ -445,7 +447,6 @@ static irqreturn_t si1145_trigger_handler(int irq, void *private) * 6*2 bytes channels data + 4 bytes alignment + * 8 bytes timestamp */ - u8 buffer[24]; int i, j = 0; int ret; u8 irq_status = 0; @@ -478,7 +479,7 @@ static irqreturn_t si1145_trigger_handler(int irq, void *private) ret = i2c_smbus_read_i2c_block_data_or_emulated( data->client, indio_dev->channels[i].address, - sizeof(u16) * run, &buffer[j]); + sizeof(u16) * run, &data->buffer[j]); if (ret < 0) goto done; j += run * sizeof(u16); @@ -493,7 +494,7 @@ static irqreturn_t si1145_trigger_handler(int irq, void *private) goto done; } - iio_push_to_buffers_with_timestamp(indio_dev, buffer, + iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, iio_get_time_ns(indio_dev)); done: