| Message ID | 20200629100537.20365-2-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles | expand |
On Mon, 29 Jun 2020 12:05:37 +0200 Krzysztof Kozlowski <krzk@kernel.org> wrote: > The compatible for BMM150 should not have "_magn" suffix because, unlike > two other Bosch devices, it is only a magnetometer. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Both applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to ignore them. Thanks for tidying this up. Jonathan > > --- > > Changes since v2: > 1. Add compatible only for bmm150. > > Changes since v1: > 1. New patch. > --- > drivers/iio/magnetometer/bmc150_magn_i2c.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c > index fb45b63c56e4..876e96005e33 100644 > --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c > +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c > @@ -58,7 +58,8 @@ MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id); > static const struct of_device_id bmc150_magn_of_match[] = { > { .compatible = "bosch,bmc150_magn" }, > { .compatible = "bosch,bmc156_magn" }, > - { .compatible = "bosch,bmm150_magn" }, > + { .compatible = "bosch,bmm150_magn" }, /* deprecated compatible */ > + { .compatible = "bosch,bmm150" }, > { } > }; > MODULE_DEVICE_TABLE(of, bmc150_magn_of_match);
diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c index fb45b63c56e4..876e96005e33 100644 --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c @@ -58,7 +58,8 @@ MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id); static const struct of_device_id bmc150_magn_of_match[] = { { .compatible = "bosch,bmc150_magn" }, { .compatible = "bosch,bmc156_magn" }, - { .compatible = "bosch,bmm150_magn" }, + { .compatible = "bosch,bmm150_magn" }, /* deprecated compatible */ + { .compatible = "bosch,bmm150" }, { } }; MODULE_DEVICE_TABLE(of, bmc150_magn_of_match);
The compatible for BMM150 should not have "_magn" suffix because, unlike two other Bosch devices, it is only a magnetometer. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v2: 1. Add compatible only for bmm150. Changes since v1: 1. New patch. --- drivers/iio/magnetometer/bmc150_magn_i2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)