| Message ID | 20200716135928.1456727-18-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | First batch of W=1 fixes for IIO | expand |
On Thu, 16 Jul 2020 14:59:15 +0100 Lee Jones <lee.jones@linaro.org> wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/ad7949.c:58: warning: Function parameter or member 'indio_dev' not described in 'ad7949_adc_chip' > drivers/iio/adc/ad7949.c:58: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7949_adc_chip' Holding this one pending discussion of whether to add ___cacheline_aligned to the stuff kernel-doc effectively skips when processing structures. Jonathan > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Cc: Charles-Antoine Couret <charles-antoine.couret@essensium.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/iio/adc/ad7949.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c > index 2c6f60edb7ced..a3fc42617feb9 100644 > --- a/drivers/iio/adc/ad7949.c > +++ b/drivers/iio/adc/ad7949.c > @@ -39,7 +39,7 @@ static const struct ad7949_adc_spec ad7949_adc_spec[] = { > * struct ad7949_adc_chip - AD ADC chip > * @lock: protects write sequences > * @vref: regulator generating Vref > - * @iio_dev: reference to iio structure > + * @indio_dev: reference to iio structure > * @spi: reference to spi structure > * @resolution: resolution of the chip > * @cfg: copy of the configuration register > @@ -54,7 +54,7 @@ struct ad7949_adc_chip { > u8 resolution; > u16 cfg; > unsigned int current_channel; > - u16 buffer ____cacheline_aligned; > + u16 ____cacheline_aligned buffer; > }; > > static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val,
diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c index 2c6f60edb7ced..a3fc42617feb9 100644 --- a/drivers/iio/adc/ad7949.c +++ b/drivers/iio/adc/ad7949.c @@ -39,7 +39,7 @@ static const struct ad7949_adc_spec ad7949_adc_spec[] = { * struct ad7949_adc_chip - AD ADC chip * @lock: protects write sequences * @vref: regulator generating Vref - * @iio_dev: reference to iio structure + * @indio_dev: reference to iio structure * @spi: reference to spi structure * @resolution: resolution of the chip * @cfg: copy of the configuration register @@ -54,7 +54,7 @@ struct ad7949_adc_chip { u8 resolution; u16 cfg; unsigned int current_channel; - u16 buffer ____cacheline_aligned; + u16 ____cacheline_aligned buffer; }; static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val,
Kerneldoc gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/ad7949.c:58: warning: Function parameter or member 'indio_dev' not described in 'ad7949_adc_chip' drivers/iio/adc/ad7949.c:58: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7949_adc_chip' Cc: Michael Hennerich <Michael.Hennerich@analog.com> Cc: Charles-Antoine Couret <charles-antoine.couret@essensium.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/iio/adc/ad7949.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)