| Message ID | 20200716135928.1456727-26-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | First batch of W=1 fixes for IIO | expand |
On Thu, 16 Jul 2020 14:59:23 +0100 Lee Jones <lee.jones@linaro.org> wrote: > Attribute descriptions must match the name exactly. > > Kerneldoc expects attributes/parameters to be in '@*.: ' format. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5764.c:42: warning: Function parameter or member 'channels' not described in 'ad5764_chip_info' > drivers/iio/dac/ad5764.c:67: warning: Function parameter or member 'lock' not described in 'ad5764_state' > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied. Thanks, Jonathan > --- > drivers/iio/dac/ad5764.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/dac/ad5764.c b/drivers/iio/dac/ad5764.c > index 5b0f0fe354f6b..1e16c464241c4 100644 > --- a/drivers/iio/dac/ad5764.c > +++ b/drivers/iio/dac/ad5764.c > @@ -33,9 +33,8 @@ > * struct ad5764_chip_info - chip specific information > * @int_vref: Value of the internal reference voltage in uV - 0 if external > * reference voltage is used > - * @channel channel specification > + * @channels: channel specification > */ > - > struct ad5764_chip_info { > unsigned long int_vref; > const struct iio_chan_spec *channels; > @@ -46,7 +45,7 @@ struct ad5764_chip_info { > * @spi: spi_device > * @chip_info: chip info > * @vref_reg: vref supply regulators > - * @lock lock to protect the data buffer during SPI ops > + * @lock: lock to protect the data buffer during SPI ops > * @data: spi transfer buffers > */ >
diff --git a/drivers/iio/dac/ad5764.c b/drivers/iio/dac/ad5764.c index 5b0f0fe354f6b..1e16c464241c4 100644 --- a/drivers/iio/dac/ad5764.c +++ b/drivers/iio/dac/ad5764.c @@ -33,9 +33,8 @@ * struct ad5764_chip_info - chip specific information * @int_vref: Value of the internal reference voltage in uV - 0 if external * reference voltage is used - * @channel channel specification + * @channels: channel specification */ - struct ad5764_chip_info { unsigned long int_vref; const struct iio_chan_spec *channels; @@ -46,7 +45,7 @@ struct ad5764_chip_info { * @spi: spi_device * @chip_info: chip info * @vref_reg: vref supply regulators - * @lock lock to protect the data buffer during SPI ops + * @lock: lock to protect the data buffer during SPI ops * @data: spi transfer buffers */
Attribute descriptions must match the name exactly. Kerneldoc expects attributes/parameters to be in '@*.: ' format. Fixes the following W=1 kernel build warning(s): drivers/iio/dac/ad5764.c:42: warning: Function parameter or member 'channels' not described in 'ad5764_chip_info' drivers/iio/dac/ad5764.c:67: warning: Function parameter or member 'lock' not described in 'ad5764_state' Cc: Michael Hennerich <Michael.Hennerich@analog.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/iio/dac/ad5764.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)