| Message ID | 20200916083128.73729-1-alexandru.ardelean@analog.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: ad9467: refine mismatch vs unknown chip-id messages | expand |
On Wed, 16 Sep 2020 11:31:28 +0300 Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > We should probably print what the expected chip-ID is. We already have > that information available, based on the device specified via > device-tree. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> applied. thanks, Jonathan > --- > drivers/iio/adc/ad9467.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > index 8a6682b567be..f068256cfca9 100644 > --- a/drivers/iio/adc/ad9467.c > +++ b/drivers/iio/adc/ad9467.c > @@ -390,7 +390,8 @@ static int ad9467_probe(struct spi_device *spi) > > id = ad9467_spi_read(spi, AN877_ADC_REG_CHIP_ID); > if (id != conv->chip_info->id) { > - dev_err(&spi->dev, "Unrecognized CHIP_ID 0x%X\n", id); > + dev_err(&spi->dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", > + id, conv->chip_info->id); > return -ENODEV; > } >
diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c index 8a6682b567be..f068256cfca9 100644 --- a/drivers/iio/adc/ad9467.c +++ b/drivers/iio/adc/ad9467.c @@ -390,7 +390,8 @@ static int ad9467_probe(struct spi_device *spi) id = ad9467_spi_read(spi, AN877_ADC_REG_CHIP_ID); if (id != conv->chip_info->id) { - dev_err(&spi->dev, "Unrecognized CHIP_ID 0x%X\n", id); + dev_err(&spi->dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", + id, conv->chip_info->id); return -ENODEV; }
We should probably print what the expected chip-ID is. We already have that information available, based on the device specified via device-tree. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> --- drivers/iio/adc/ad9467.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)