diff mbox series

[3/9] ARM: dts: Cygnus: Drop incorrect io-channel-ranges property.

Message ID 20201115192951.1073632-4-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: IIO: Drop wrong use of io-channel-ranges then drop it as well. | expand

Commit Message

Jonathan Cameron Nov. 15, 2020, 7:29 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This property applies to consumers of io-channels.  In this case we
have a provider so the property is not used.

Not dt_schema will now detect this as an error due to a dependency
between this property and the io-channels property.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm/boot/dts/bcm-cygnus.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Florian Fainelli Nov. 16, 2020, 3:23 a.m. UTC | #1 
On 11/15/2020 11:29 AM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> This property applies to consumers of io-channels.  In this case we
> have a provider so the property is not used.
> 
> Not dt_schema will now detect this as an error due to a dependency
> between this property and the io-channels property.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>

Applied to devicetree/next, with the second paragraph fixed to:

"""
Recent changes to dt-schema result int his being reported as an error
as a dependency is enforced between this property and io-channels.
""""

since it did not look like a correct sentence making sense otherwise.

PS: please make sure you run get_maintainer.pl, this patch did not land
in our patchwork instance since bcm-kernel-feedback-list@broadcom.com
was not copied.

Thanks you
Jonathan Cameron Nov. 16, 2020, 9:44 a.m. UTC | #2 
On Sun, 15 Nov 2020 19:23:21 -0800
Florian Fainelli <f.fainelli@gmail.com> wrote:

> On 11/15/2020 11:29 AM, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > This property applies to consumers of io-channels.  In this case we
> > have a provider so the property is not used.
> > 
> > Not dt_schema will now detect this as an error due to a dependency
> > between this property and the io-channels property.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Florian Fainelli <f.fainelli@gmail.com>  
> 
> Applied to devicetree/next, with the second paragraph fixed to:
> 
> """
> Recent changes to dt-schema result int his being reported as an error
> as a dependency is enforced between this property and io-channels.
> """"
> 
> since it did not look like a correct sentence making sense otherwise.
Oops. I shouldn't write patch descriptions on a Sunday evening.  Indeed
it was garbage.

> 
> PS: please make sure you run get_maintainer.pl, this patch did not land
> in our patchwork instance since bcm-kernel-feedback-list@broadcom.com
> was not copied.

Sorry, these cross tree patch series are a bit of a pain to deal with
but I should have picked up on that one.

Jonathan

> 
> Thanks you
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index dacaef2c14ca..0025c88f660c 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -591,7 +591,6 @@  touchscreen: touchscreen@180a6000 {
 		adc: adc@180a6000 {
 			compatible = "brcm,iproc-static-adc";
 			#io-channel-cells = <1>;
-			io-channel-ranges;
 			adc-syscon = <&ts_adc_syscon>;
 			clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
 			clock-names = "tsc_clk";