| Message ID | 20210202181427.3934218-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: iio: dac: Add missing ad5686 compatible strings | expand |
On 2/2/21 7:14 PM, Rob Herring wrote: > The example uses 'adi,ad5686', but the schema fails to document it. Given > the filename and there is a similar part AD5686, let's just add the > compatible strings including the 'r' variant. There are two variants of this chip. One with a SPI interface and one with a I2C interface. This binding document only describes the I2C variants. But the ad5686 is a SPI variant. I think this is a typo and we should replace ad5686 with ad5696, including the document name. > > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > Cc: Michael Auchter <michael.auchter@ni.com> > Cc: linux-iio@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > index 8065228e5df8..190919291828 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > @@ -19,6 +19,8 @@ properties: > - adi,ad5338r > - adi,ad5671r > - adi,ad5675r > + - adi,ad5686 > + - adi,ad5686r > - adi,ad5691r > - adi,ad5692r > - adi,ad5693
On Tue, Feb 02, 2021 at 09:55:56PM +0100, Lars-Peter Clausen wrote: > On 2/2/21 7:14 PM, Rob Herring wrote: > > The example uses 'adi,ad5686', but the schema fails to document it. Given > > the filename and there is a similar part AD5686, let's just add the > > compatible strings including the 'r' variant. > > There are two variants of this chip. One with a SPI interface and one with a > I2C interface. This binding document only describes the I2C variants. But > the ad5686 is a SPI variant. Right, I should have noticed that. > I think this is a typo and we should replace ad5686 with ad5696, including > the document name. Though we do frequently document both I2C and SPI variants in the same binding, given there's no existing SPI support and the example is wrong I agree. > > > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > > Cc: Jonathan Cameron <jic23@kernel.org> > > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > > Cc: Michael Auchter <michael.auchter@ni.com> > > Cc: linux-iio@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > index 8065228e5df8..190919291828 100644 > > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > @@ -19,6 +19,8 @@ properties: > > - adi,ad5338r > > - adi,ad5671r > > - adi,ad5675r > > + - adi,ad5686 > > + - adi,ad5686r > > - adi,ad5691r > > - adi,ad5692r > > - adi,ad5693 > >
On Tue, 2 Feb 2021 15:10:22 -0600 Rob Herring <robh@kernel.org> wrote: > On Tue, Feb 02, 2021 at 09:55:56PM +0100, Lars-Peter Clausen wrote: > > On 2/2/21 7:14 PM, Rob Herring wrote: > > > The example uses 'adi,ad5686', but the schema fails to document it. Given > > > the filename and there is a similar part AD5686, let's just add the > > > compatible strings including the 'r' variant. > > > > There are two variants of this chip. One with a SPI interface and one with a > > I2C interface. This binding document only describes the I2C variants. But > > the ad5686 is a SPI variant. > > Right, I should have noticed that. > > > I think this is a typo and we should replace ad5686 with ad5696, including > > the document name. > > Though we do frequently document both I2C and SPI variants in the same > binding, given there's no existing SPI support and the example is wrong > I agree. Ah, this is what I get for reading my emails out of order. There is existing SPI driver support if that's what you mean we just haven't documented the binding for it. Should work via the fallbacks in SPI that drop the vendor id off then match on the rest. As I mentioned in reply to v2. It's an old driver so kind of got DT support by accident. I'll play catch up at some stage soon on missing binding docs, (I suspect there are quite a few for older IIO drivers) Thanks, Jonathan > > > > > > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > > > Cc: Jonathan Cameron <jic23@kernel.org> > > > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > > > Cc: Michael Auchter <michael.auchter@ni.com> > > > Cc: linux-iio@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > > index 8065228e5df8..190919291828 100644 > > > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > > @@ -19,6 +19,8 @@ properties: > > > - adi,ad5338r > > > - adi,ad5671r > > > - adi,ad5675r > > > + - adi,ad5686 > > > + - adi,ad5686r > > > - adi,ad5691r > > > - adi,ad5692r > > > - adi,ad5693 > > > >
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml index 8065228e5df8..190919291828 100644 --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml @@ -19,6 +19,8 @@ properties: - adi,ad5338r - adi,ad5671r - adi,ad5675r + - adi,ad5686 + - adi,ad5686r - adi,ad5691r - adi,ad5692r - adi,ad5693
The example uses 'adi,ad5686', but the schema fails to document it. Given the filename and there is a similar part AD5686, let's just add the compatible strings including the 'r' variant. Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Michael Hennerich <Michael.Hennerich@analog.com> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: Michael Auchter <michael.auchter@ni.com> Cc: linux-iio@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++ 1 file changed, 2 insertions(+)