| Message ID | 20210509113354.660190-16-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | IIO: Runtime PM related cleanups. | expand |
On 5/9/21 1:33 PM, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > --- > drivers/iio/adc/stm32-dfsdm-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Hi Jonathan, Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Thanks for the patch, Regards, Fabrice > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index bb925a11c8ae..a627af9a825e 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -135,11 +135,9 @@ int stm32_dfsdm_start_dfsdm(struct stm32_dfsdm *dfsdm) > int ret; > > if (atomic_inc_return(&priv->n_active_ch) == 1) { > - ret = pm_runtime_get_sync(dev); > - if (ret < 0) { > - pm_runtime_put_noidle(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret < 0) > goto error_ret; > - } > > /* select clock source, e.g. 0 for "dfsdm" or 1 for "audio" */ > clk_src = priv->aclk ? 1 : 0; >
Em Sun, 9 May 2021 12:33:41 +0100 Jonathan Cameron <jic23@kernel.org> escreveu: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> LGTM. Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/iio/adc/stm32-dfsdm-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index bb925a11c8ae..a627af9a825e 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -135,11 +135,9 @@ int stm32_dfsdm_start_dfsdm(struct stm32_dfsdm *dfsdm) > int ret; > > if (atomic_inc_return(&priv->n_active_ch) == 1) { > - ret = pm_runtime_get_sync(dev); > - if (ret < 0) { > - pm_runtime_put_noidle(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret < 0) > goto error_ret; > - } > > /* select clock source, e.g. 0 for "dfsdm" or 1 for "audio" */ > clk_src = priv->aclk ? 1 : 0; Thanks, Mauro
On Wed, 12 May 2021 15:31:33 +0200 Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote: > On 5/9/21 1:33 PM, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Found using coccicheck script under review at: > > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > > in general. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > > --- > > drivers/iio/adc/stm32-dfsdm-core.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > Hi Jonathan, > > Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Applied, thanks > > Thanks for the patch, > Regards, > Fabrice > > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > > index bb925a11c8ae..a627af9a825e 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-core.c > > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > > @@ -135,11 +135,9 @@ int stm32_dfsdm_start_dfsdm(struct stm32_dfsdm *dfsdm) > > int ret; > > > > if (atomic_inc_return(&priv->n_active_ch) == 1) { > > - ret = pm_runtime_get_sync(dev); > > - if (ret < 0) { > > - pm_runtime_put_noidle(dev); > > + ret = pm_runtime_resume_and_get(dev); > > + if (ret < 0) > > goto error_ret; > > - } > > > > /* select clock source, e.g. 0 for "dfsdm" or 1 for "audio" */ > > clk_src = priv->aclk ? 1 : 0; > >
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c index bb925a11c8ae..a627af9a825e 100644 --- a/drivers/iio/adc/stm32-dfsdm-core.c +++ b/drivers/iio/adc/stm32-dfsdm-core.c @@ -135,11 +135,9 @@ int stm32_dfsdm_start_dfsdm(struct stm32_dfsdm *dfsdm) int ret; if (atomic_inc_return(&priv->n_active_ch) == 1) { - ret = pm_runtime_get_sync(dev); - if (ret < 0) { - pm_runtime_put_noidle(dev); + ret = pm_runtime_resume_and_get(dev); + if (ret < 0) goto error_ret; - } /* select clock source, e.g. 0 for "dfsdm" or 1 for "audio" */ clk_src = priv->aclk ? 1 : 0;