diff mbox series

[2/7] staging:iio:addac:adt7316: Cleanup includes

Message ID 20210611152614.109361-3-jic23@kernel.org (mailing list archive)
State Superseded
Headers show
Series staging:iio: Header cleanup | expand

Commit Message

Jonathan Cameron June 11, 2021, 3:26 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Result of consideration of the output of the include-what-you-use
tool.  Also a forwards definition of device to avoid any
ordering of headers issues.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/staging/iio/addac/adt7316.c | 5 -----
 drivers/staging/iio/addac/adt7316.h | 1 +
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Andy Shevchenko June 11, 2021, 5:40 p.m. UTC | #1 
On Fri, Jun 11, 2021 at 6:25 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Result of consideration of the output of the include-what-you-use
> tool.  Also a forwards definition of device to avoid any
> ordering of headers issues.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/staging/iio/addac/adt7316.c | 5 -----
>  drivers/staging/iio/addac/adt7316.h | 1 +
>  2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index ccbafcaaf27e..e81791ee182f 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -8,14 +8,9 @@
>  #include <linux/interrupt.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/irq.h>
> -#include <linux/workqueue.h>
>  #include <linux/device.h>
>  #include <linux/kernel.h>
> -#include <linux/slab.h>
>  #include <linux/sysfs.h>
> -#include <linux/list.h>
> -#include <linux/i2c.h>
> -#include <linux/rtc.h>
>  #include <linux/module.h>
>
>  #include <linux/iio/iio.h>
> diff --git a/drivers/staging/iio/addac/adt7316.h b/drivers/staging/iio/addac/adt7316.h
> index 8c2a92ae7157..a1f6324ead59 100644
> --- a/drivers/staging/iio/addac/adt7316.h
> +++ b/drivers/staging/iio/addac/adt7316.h
> @@ -10,6 +10,7 @@
>
>  #include <linux/types.h>
>  #include <linux/pm.h>

+ blank line?

> +struct device;
>
>  #define ADT7316_REG_MAX_ADDR           0x3F
>
> --
> 2.31.1
>
diff mbox series

Patch

diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index ccbafcaaf27e..e81791ee182f 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -8,14 +8,9 @@ 
 #include <linux/interrupt.h>
 #include <linux/gpio/consumer.h>
 #include <linux/irq.h>
-#include <linux/workqueue.h>
 #include <linux/device.h>
 #include <linux/kernel.h>
-#include <linux/slab.h>
 #include <linux/sysfs.h>
-#include <linux/list.h>
-#include <linux/i2c.h>
-#include <linux/rtc.h>
 #include <linux/module.h>
 
 #include <linux/iio/iio.h>
diff --git a/drivers/staging/iio/addac/adt7316.h b/drivers/staging/iio/addac/adt7316.h
index 8c2a92ae7157..a1f6324ead59 100644
--- a/drivers/staging/iio/addac/adt7316.h
+++ b/drivers/staging/iio/addac/adt7316.h
@@ -10,6 +10,7 @@ 
 
 #include <linux/types.h>
 #include <linux/pm.h>
+struct device;
 
 #define ADT7316_REG_MAX_ADDR		0x3F