diff mbox series

[11/15] dt-bindings: iio: dac: ad5761: Add missing binding doc.

Message ID 20210627163244.1090296-12-jic23@kernel.org (mailing list archive)
State Accepted
Headers show
Series dt-bindings: iio: dac: Add most missing binding documents. | expand

Commit Message

Jonathan Cameron June 27, 2021, 4:32 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Straight forward binding with vref optional for those part with internal
regulators, but required for those without.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Ricardo Ribalda <ribalda@kernel.org>
---
 .../bindings/iio/dac/adi,ad5761.yaml          | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)

Comments

Rob Herring (Arm) July 14, 2021, 3:58 p.m. UTC | #1 
On Sun, 27 Jun 2021 17:32:40 +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Straight forward binding with vref optional for those part with internal
> regulators, but required for those without.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Ricardo Ribalda <ribalda@kernel.org>
> ---
>  .../bindings/iio/dac/adi,ad5761.yaml          | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Ricardo Ribalda Delgado July 27, 2021, 10:52 a.m. UTC | #2 
Sorry for the late reply, holiday season :). Thanks for the patch

Acked-by: Ricardo Ribalda <ribalda@kernel.org>

On Wed, Jul 14, 2021 at 5:58 PM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, 27 Jun 2021 17:32:40 +0100, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Straight forward binding with vref optional for those part with internal
> > regulators, but required for those without.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Ricardo Ribalda <ribalda@kernel.org>
> > ---
> >  .../bindings/iio/dac/adi,ad5761.yaml          | 60 +++++++++++++++++++
> >  1 file changed, 60 insertions(+)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5761.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5761.yaml
new file mode 100644
index 000000000000..7f95a9ed55fe
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5761.yaml
@@ -0,0 +1,60 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/adi,ad5761.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5761 and similar DACs
+
+maintainers:
+  - Ricardo Ribalda <ribalda@kernel.org>
+  - Jonathan Cameron <jic23@kernel.org>
+
+properties:
+
+  compatible:
+    enum:
+      - adi,ad5721
+      - adi,ad5721r
+      - adi,ad5761
+      - adi,ad5761r
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency: true
+
+  vref-supply:
+    description: If not supplied, internal reference will be used.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - adi,ad5721
+              - adi,ad5761
+    then:
+      required:
+        - vref-supply
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        dac@0 {
+            compatible = "adi,ad5721";
+            reg = <0>;
+            vref-supply = <&dac_vref>;
+        };
+    };
+...