| Message ID | 20210825152518.379386-25-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | TI AM437X ADC1 | expand |
On Wed, 25 Aug 2021 17:25:02 +0200 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > The error message if we cannot retrieve the clock tells us that the > touchscreen controller clock was unavailable. This is wrong, this is the > "main" clock for the hardware block, it is not specific to the > touchscreen and won't change when we will introduce ADC1/magnetic reader > support so let's corret this comment. correct > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/mfd/ti_am335x_tscadc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > index 047426a74a2e..2f934fd2154a 100644 > --- a/drivers/mfd/ti_am335x_tscadc.c > +++ b/drivers/mfd/ti_am335x_tscadc.c > @@ -206,7 +206,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) > */ > clk = devm_clk_get(&pdev->dev, NULL); > if (IS_ERR(clk)) { > - dev_err(&pdev->dev, "failed to get TSC fck\n"); > + dev_err(&pdev->dev, "failed to get fck\n"); > err = PTR_ERR(clk); > goto err_disable_clk; > }
diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 047426a74a2e..2f934fd2154a 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -206,7 +206,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) */ clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(clk)) { - dev_err(&pdev->dev, "failed to get TSC fck\n"); + dev_err(&pdev->dev, "failed to get fck\n"); err = PTR_ERR(clk); goto err_disable_clk; }
The error message if we cannot retrieve the clock tells us that the touchscreen controller clock was unavailable. This is wrong, this is the "main" clock for the hardware block, it is not specific to the touchscreen and won't change when we will introduce ADC1/magnetic reader support so let's corret this comment. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mfd/ti_am335x_tscadc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)