diff mbox series

iio: adc: at91-sama5d2_adc: fix warning for uninitialized 'val' variable

Message ID 20210831064800.78979-1-eugen.hristev@microchip.com (mailing list archive)
State Accepted
Headers show
Series iio: adc: at91-sama5d2_adc: fix warning for uninitialized 'val' variable | expand

Commit Message

Eugen Hristev Aug. 31, 2021, 6:48 a.m. UTC 
>> drivers/iio/adc/at91-sama5d2_adc.c:722:11: warning: variable 'val' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           else if (reg == st->soc_info.platform->layout->YPOSR)
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/adc/at91-sama5d2_adc.c:725:7: note: uninitialized use occurs here
           if (!val)
                ^~~
   drivers/iio/adc/at91-sama5d2_adc.c:722:7: note: remove the 'if' if its condition is always true
           else if (reg == st->soc_info.platform->layout->YPOSR)
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/adc/at91-sama5d2_adc.c:711:9: note: initialize the variable 'val' to silence this warning
           u32 val;
                  ^
                   = 0
   1 warning generated.

Fixed by initializing 'val' variable.

Fixes: 29edec2b98ff ("iio: adc: at91-sama5d2_adc: convert to platform specific data structures")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---

Hi Jonathan,

If you can still rebase your testing branch, maybe you can squash this into the
original patch, no need to make a separate commit I guess.
I fixed this as soon as the report came out from the 0day robot.

Thanks !
Eugen

 drivers/iio/adc/at91-sama5d2_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index 29c7441f9f27..f8a9ad50a00b 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -846,7 +846,7 @@  static int at91_adc_configure_touch(struct at91_adc_state *st, bool state)
 
 static u16 at91_adc_touch_pos(struct at91_adc_state *st, int reg)
 {
-	u32 val;
+	u32 val = 0;
 	u32 scale, result, pos;
 
 	/*