| Message ID | 20210920173624.21406-1-tim.gardner@canonical.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [next] counter: Add default statement to switch() in quad8_function_read() | expand |
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index c587f295d720..3a69d35b82ea 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -215,6 +215,8 @@ static int quad8_function_read(struct counter_device *counter, case 2: *function = COUNTER_FUNCTION_QUADRATURE_X4; break; + default: + return -1; } else *function = COUNTER_FUNCTION_PULSE_DIRECTION;
Coverity complains of a possible use of an uninitialized variable in quad8_action_read(). CID 119643 (#1 of 1): Uninitialized scalar variable (UNINIT) 4. uninit_use: Using uninitialized value function. 346 switch (function) { The call to quad8_function_read() could theoretically return without assigning a value to '*function', thus causing the use of an ininitialized variable 'function' in quad8_action_read(). Fix this by adding a default statement to the switch in quad8_function_read() and returning an error. William Breathitt Gray <vilhelm.gray@gmail.com> Syed Nayyar Waris <syednwaris@gmail.com> linux-iio@vger.kernel.org linux-kernel@vger.kernel.org Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- drivers/counter/104-quad-8.c | 2 ++ 1 file changed, 2 insertions(+)